Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): Implement task timeouts and heartbeats for runners (no-changelog) #11690

Open
wants to merge 37 commits into
base: master
Choose a base branch
from
Open

feat(core): Implement task timeouts and heartbeats for runners (no-changelog) #11690

wants to merge 37 commits into from
+515 −35

Conversation

ivov
Copy link
Contributor

@ivov ivov commented Nov 12, 2024 •
edited
Loading

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Nov 12, 2024
@codecov Codecov
Copy link

codecov bot commented Nov 12, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 56.63717% with 49 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
packages/cli/src/runners/runner-ws-server.ts 54.83% 13 Missing and 1 partial ⚠️
packages/cli/src/runners/task-runner-process.ts 35.29% 11 Missing ⚠️
...nners/errors/task-runner-failed-heartbeat.error.ts 16.66% 10 Missing ⚠️
packages/cli/src/runners/task-broker.service.ts 66.66% 6 Missing and 2 partials ⚠️
...runners/default-task-runner-disconnect-analyzer.ts 57.14% 1 Missing and 2 partials ⚠️
...unners/internal-task-runner-disconnect-analyzer.ts 0.00% 3 Missing ⚠️

📢 Thoughts on this report? Let us know!

@ivov ivov changed the title feat(core): Implement task timeouts for runners (no-changelog) feat(core): Implement task timeouts and heartbeats for runners (no-changelog) Nov 12, 2024
@ivov ivov marked this pull request as ready for review November 12, 2024 16:54
tomi
tomi reviewed Nov 13, 2024
View reviewed changes
Copy link
Contributor

@tomi tomi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works very nicely 👏 Some comments about the implementation

packages/@n8n/task-runner/src/task-runner-server.ts Outdated Show resolved Hide resolved
packages/@n8n/task-runner/src/task-runner-server.ts Outdated Show resolved Hide resolved
packages/@n8n/task-runner/src/task-runner-server.ts Outdated Show resolved Hide resolved
packages/@n8n/task-runner/src/start.ts Outdated Show resolved Hide resolved
packages/cli/src/runners/task-runner-server.ts Outdated Show resolved Hide resolved
packages/cli/src/runners/runner-ws-server.ts Outdated Show resolved Hide resolved
packages/cli/src/runners/task-broker.service.ts Outdated Show resolved Hide resolved
packages/cli/src/runners/task-runner-process.ts Outdated Show resolved Hide resolved
packages/cli/src/runners/task-runner-process.ts Outdated Show resolved Hide resolved
packages/@n8n/config/src/configs/runners.config.ts Outdated Show resolved Hide resolved
@ivov
Copy link
Contributor Author

ivov commented Nov 14, 2024

@tomi Thanks as always, learning a lot from this review 🙏🏻

@ivov ivov requested a review from tomi November 14, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomi tomi Awaiting requested review from tomi

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ivov @tomi