Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Github star button in-app #11695

Merged
merged 11 commits into from
Nov 13, 2024
Merged

feat: Github star button in-app #11695

merged 11 commits into from
Nov 13, 2024
+97 −122

Conversation

michael-radency
Copy link
Contributor

Summary

adds github star button
image
image

Related Linear tickets, Github issues, and Community forum posts

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@michael-radency michael-radency added ui Enhancement in /editor-ui or /design-system n8n team Authored by the n8n team labels Nov 12, 2024
@codecov Codecov
Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

ShireenMissi
ShireenMissi previously approved these changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@ShireenMissi ShireenMissi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@github-actions GitHub Actions
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

@cypress Cypress
Copy link

cypress bot commented Nov 13, 2024 •
edited
Loading

n8n    Run #7865

Run Properties:  status check passed Passed #7865  •  git commit 0bcc363841: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 michael-radency 🗃️ e2e/*
Project n8n
Branch Review node-1974-add-a-github-star-button-in-app
Run status status check passed Passed #7865
Run duration 04m 30s
Commit git commit 0bcc363841: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 michael-radency 🗃️ e2e/*
Committer Michael Kret
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 2
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 470
View all changes introduced in this branch ↗︎

ShireenMissi
ShireenMissi previously approved these changes Nov 13, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

ShireenMissi
ShireenMissi previously approved these changes Nov 13, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@github-actions GitHub Actions
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

2 similar comments
@github-actions GitHub Actions
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

@github-actions GitHub Actions
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

@github-actions GitHub Actions
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

@github-actions GitHub Actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@ShireenMissi ShireenMissi merged commit 0fd684d into master Nov 13, 2024
35 checks passed
@ShireenMissi ShireenMissi deleted the node-1974-add-a-github-star-button-in-app branch November 13, 2024 16:10
@github-actions github-actions bot mentioned this pull request Nov 13, 2024
Merged
@janober
Copy link
Member

janober commented Nov 13, 2024

Got released with [email protected]

burivuhster pushed a commit that referenced this pull request Nov 14, 2024
@michael-radency @burivuhster
feat: Github star button in-app (#11695)
83511fc
netroy
netroy reviewed Nov 14, 2024
View reviewed changes
cypress/e2e/1-workflows.cy.ts
@@ -23,6 +23,7 @@ describe('Workflows', () => {
});

it('should create multiple new workflows using add workflow button', () => {
cy.viewport(1920, 1080);
Copy link
Member

@netroy netroy Nov 14, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of expanding the viewport (which doesn't always seems to work), I think we should disable this button in e2e tests, since there is no value having this in the tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@netroy netroy netroy left review comments

@ShireenMissi ShireenMissi ShireenMissi approved these changes

Assignees
No one assigned
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@michael-radency @janober @netroy @ShireenMissi