-
Notifications
You must be signed in to change notification settings - Fork 7.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(editor): Add workflow evaluation edit and list views (no-changelog) #11719
Open
OlegIvaniv
wants to merge
23
commits into
master
Choose a base branch
from
ai-426-frontend-test-viewedit-screen_rebased
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,942
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Created evaluations API endpoints - Implemented evaluations store - Updated NewWorkflowEvaluationView - RenamedRun Test to Save Test
- Update GlobalExecutionsList.vue - Update PageViewLayout.vue - Define --content-container-width - Update ProjectSettings.vue - Update TemplatesView.vue
• Move components to dedicated files • Create new EvaluationEditView component • Update router configuration • Relocate useEvaluationForm composable • Add new types for evaluations
• Split EmptyState into separate component • Create TestItem and TestsList components • Update EvaluationListView with new components • Add WORKFLOW_EVALUATION_EDIT to constants • Improve styles and layout of test items
- Add feature flag check - Update UI to show/hide evaluation tab - Fetch tags for test definitions - Handle routing when feature is disabled - Cleanup console logs
• Adjust padding and cursor for TestItem • Update button sizes and spacing • Modify TestItem title styling • Remove size and type from TestsList button
• Make createTag prop optional • Add eventBus prop to TagsDropdown • Update TagsInput to use TagsDropdown • Remove unnecessary class in TagsInput • Adjust prop types and imports
…ents • Add localization for UI text • Improve styling and layout consistency • Refactor component props and structure • Update button labels and placeholders
- Update MainHeader tab logic - Enhance EmptyState component styling - Add localization for test list texts - Adjust TestsList component - Update locale file
…ation • Remove dependency on tagsStore • Add field-specific error handling • Simplify loadTestData and saveTest methods • Update EvaluationEditView component • Improve UI feedback for form errors
- Add data-test-id to input components - Update TagsInput to use useI18n composable - Fix typo in TestsList component - Add test ID to "Run Test" button - Remove unused locale references
- Add MetricsInput component tests - Add TagsInput component tests - Add EvaluationEditView tests - Include snapshot test - Update test utilities and mocks
- Add auto-save functionality - Improve error handling in saveTest - Update URL after creating new test
…test-definition' into ai-426-frontend-test-viewedit-screen_rebased
n8n-assistant
bot
added
n8n team
Authored by the n8n team
ui
Enhancement in /editor-ui or /design-system
labels
Nov 13, 2024
• Add description to test definition interface • Include description in create/update params • Update UI to handle description field • Refactor types for better consistency • Add data-test-id for E2E testing
OlegIvaniv
force-pushed
the
ai-426-frontend-test-viewedit-screen_rebased
branch
from
November 13, 2024 15:05
732e417
to
9b5be7a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new Workflow Evaluation feature that allows users to create, list, and edit test definitions for workflows. The feature is currently behind the
025_workflow_evaluation
feature flag as it's still in development.Key Features
Implementation Details
Note
window.featureFlags.override('025_workflow_evaluation', true)
/workflow/:name/evaluation
/workflow/:name/evaluation/new
/workflow/:name/evaluation/:testId
CleanShot.2024-11-13.at.13.11.20.mp4
Related Linear tickets, Github issues, and Community forum posts
Review / Merge checklist
release/backport
(if the PR is an urgent fix that needs to be backported)