ci: Hide the github button in e2e tests (no-changelog) #11747
Conversation
netroy
force-pushed
the
hide-github-botton-in-e2e-tests
branch
from
a27a70a
to
c741b8d
Compare
| @@ -184,15 +187,16 @@ async function navigateToExecutionsView(openInNewTab: boolean) { | |||
| @update:model-value="onTabSelected" | |||
| /> | |||
| </div> | |||
| <div class="github-button"> | |||
| <div class="github-button" v-if="showGitHubButton"> | |||
There was a problem hiding this comment.
can we keep it? Would be great if we can keep e2e tests as close to reality of what users experience as possible
There was a problem hiding this comment.
I think we should bring it back once/if we decide to move this to a place where it's not so obstructive. In it's current location it's messing with too many e2e tests for my liking.
There was a problem hiding this comment.
also, for us to keep this, we need a wider viewport (which also doesn't always work). To keep the user experience as close to reality as possible, we should also not be assuming a viewport width of 1920px either.
Even I don't have that wide of a viewport
There was a problem hiding this comment.
Yes, thank you for the viewport changes. Would be great to get that in.
I am still not sure about removing Github button. Based on the thread on Slack, it does not seem Product is interested in removing it.
There was a problem hiding this comment.
we are not removing the button for any other context besides e2e tests. and we probably can't revert the viewport changes, since the button is taking quite a significant horizontal space, which will likely lead to flaky tests.
There was a problem hiding this comment.
Ok. Maybe it should also be behind an env variable, but we can wait till users start asking for this.
n8n-assistant
bot
added
core
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
Summary
Related Linear tickets, Github issues, and Community forum posts
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)