adding sharing.write scope to Dropbox credentials

[kob490]

Summary

Adding the sharing.write scope to Dropbox in order to allow file share generation.

[CLAassistant]

All committers have signed the CLA.

[Joffcom]

Hey @kob490,

Thanks for the PR, We have created "GHC-794" as the internal reference to get this reviewed.

One of us will be in touch if there are any changes needed, in most cases this is normally within a couple of weeks but it depends on the current workload of the team.

[Joffcom]

Hey @kob490

Does this not need a change to the node as well to achieve the share generation or is it there and doesn't work?

[kob490]

Hey Jon. The authentication works well as-is. It just doesn't allow sharing files/folders without this scope. I tested it for my own use case and it works well just by adding this line. It does, however, require a re-authentication with Dropbox.

…

On Mon, Feb 10, 2025, 5:41 PM Jon ***@***.***> wrote: Hey @kob490 <https://github.com/kob490> Does this not need a change to the node as well to achieve the share generation or is it there and doesn't work? — Reply to this email directly, view it on GitHub <#13181 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AIWASGCDK3SBQMQR7QCNMYT2PETJPAVCNFSM6AAAAABW3TXVNOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNBZGQYTSOBYGE> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[kob490]

just to clarify, it's not dependent on the Dropbox node at all (which doesn't have the share functionality as an option). I made this change to allow a HTTP call to https://www.dropbox.com/developers/documentation/http/documentation#sharing-create_shared_link_with_settings to work with the Dropbox OAuth2 API Credential type. @Joffcom

[Joffcom]

Hey @kob490

It might be better to add the functionality to the node itself, we don't typically update a credential just for the http request node as you can use generic oauth for that although we should maybe have a special option to allow scopes to be set if it is for the http request node.

[kob490]

Hey @Joffcom ,

As per your request, I updated the PR and added the share functionality to the Dropbox node for both file and folder sharing.