Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): Unify tag search behavior #13243

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

fix(editor): Unify tag search behavior #13243

wants to merge 7 commits into from

Conversation

CharlieKolb
Copy link
Contributor

Summary

Unify tag search behavior for canvas and standalone window

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/ADO-3215/tag-search-shouldnt-be-case-sensitive

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@CharlieKolb CharlieKolb marked this pull request as ready for review February 13, 2025 11:50
@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Feb 13, 2025
Copy link

codecov bot commented Feb 13, 2025

Codecov Report

Attention: Patch coverage is 80.64516% with 6 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
packages/editor-ui/src/components/TagsDropdown.vue 84.61% 4 Missing ⚠️
...i/src/components/TagsManager/TagsView/TagsView.vue 0.00% 2 Missing ⚠️

📢 Thoughts on this report? Let us know!

Copy link
Contributor

@MiloradFilipovic MiloradFilipovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice for extracting this 🙌🏻 Looks good to me.

Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

Copy link

cypress bot commented Feb 17, 2025

n8n    Run #9289

Run Properties:  status check failed Failed #9289  •  git commit c082eee522: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 CharlieKolb 🗃️ e2e/*
Project n8n
Branch Review ADO-3215
Run status status check failed Failed #9289
Run duration 05m 58s
Commit git commit c082eee522: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 CharlieKolb 🗃️ e2e/*
Committer Charlie Kolb
View all properties for this run ↗︎

Test results
Tests that failed  Failures 3
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 5
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 433
View all changes introduced in this branch ↗︎

Tests for review

Failed  e2e/17-workflow-tags.cy.ts • 3 failed tests

View Output Video

Test Artifacts
Workflow tags > should create and attach tags inline Test Replay Screenshots Video
Workflow tags > should create tags via modal Test Replay Screenshots Video
Workflow tags > should delete all tags via modal Test Replay Screenshots Video
Flakiness  e2e/17-sharing.cy.ts • 1 flaky test

View Output Video

Test Artifacts
Credential Usage in Cross Shared Workflows > should only show credentials in their personal project for members Test Replay Screenshots Video

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants