Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(OpenAI Model Node): Add reasoning effort option to control the amount of reasoning tokens to use #13248

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

adrian-martinez-onestic
Copy link
Contributor

Summary

Follow up of PR #13103, that introduced partial support for OpenAI reasoning_effort parameter.

This PR uses native types and support from openai and @langchain/openai already available features, and completes definitions and functionality wherever seemed appropriate.

Related Linear tickets, Github issues, and Community forum posts

PR #13103
Comment #13103 (comment)

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@n8n-assistant n8n-assistant bot added community Authored by a community member node/improvement New feature or request in linear Issue or PR has been created in Linear for internal review labels Feb 13, 2025
@Joffcom
Copy link
Member

Joffcom commented Feb 13, 2025

Hey @adrian-martinez-onestic,

Thanks for the PR, We have created "GHC-831" as the internal reference to get this reviewed.

One of us will be in touch if there are any changes needed, in most cases this is normally within a couple of weeks but it depends on the current workload of the team.

Copy link

codecov bot commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@adrian-martinez-onestic adrian-martinez-onestic force-pushed the feature/openai-reasoning-effort branch from 9440f13 to c3ab3eb Compare February 13, 2025 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Authored by a community member in linear Issue or PR has been created in Linear for internal review node/improvement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants