Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): Show scrollbar in Element UI popup #13259

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

cstuncsik
Copy link
Contributor

@cstuncsik cstuncsik commented Feb 14, 2025

Summary

Credentials dropdown has no scrollbar

Related Linear tickets, Github issues, and Community forum posts

PAY-2564
Fixes: #13055

Review / Merge checklist

  • PR title and summary are descriptive.
  • Tests included.
  • PR Labeled with release/backport

Copy link

codecov bot commented Feb 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Feb 14, 2025
@cstuncsik cstuncsik marked this pull request as ready for review February 17, 2025 11:30
Copy link
Contributor

Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

Copy link

cypress bot commented Feb 17, 2025

n8n    Run #9317

Run Properties:  status check failed Failed #9317  •  git commit 2b057071f0: 🌳 pay-2564-community-issue-add-credentials-dropdown-has-no-scrollbar 🖥️ browse...
Project n8n
Branch Review pay-2564-community-issue-add-credentials-dropdown-has-no-scrollbar
Run status status check failed Failed #9317
Run duration 04m 41s
Commit git commit 2b057071f0: 🌳 pay-2564-community-issue-add-credentials-dropdown-has-no-scrollbar 🖥️ browse...
Committer Csaba Tuncsik
View all properties for this run ↗︎

Test results
Tests that failed  Failures 2
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 1
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 282
View all changes introduced in this branch ↗︎

Tests for review

Failed  12-canvas.cy.ts • 1 failed test

View Output Video

Test Artifacts
Canvas Node Manipulation and Navigation > should delete node using context menu Screenshots Video
Failed  10-undo-redo.cy.ts • 1 failed test

View Output Video

Test Artifacts
Undo/Redo > should undo/redo deleting node using context menu Test Replay Screenshots Video
Failed  9-expression-editor-modal.cy.ts • 0 failed tests

View Output

Test Artifacts
Failed  21-community-nodes.cy.ts • 0 failed tests

View Output

Test Artifacts
Failed  18-user-management.cy.ts • 0 failed tests

View Output

Test Artifacts

The first 5 failed specs are shown, see all 45 specs in Cypress Cloud.

Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

1 similar comment
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

…issue-add-credentials-dropdown-has-no-scrollbar
…issue-add-credentials-dropdown-has-no-scrollbar
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add credentials dropdown has no scrollbar
2 participants