Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): Prevent pagination setting from being overwritten in URL #13266

Merged
merged 4 commits into from
Feb 17, 2025

Conversation

MiloradFilipovic
Copy link
Contributor

Summary

Fixes a bug where pagination parameters are being dropped from URL after loading the workflow page.

Related Linear tickets, Github issues, and Community forum posts

Fixes ADO-3233

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@MiloradFilipovic MiloradFilipovic self-assigned this Feb 14, 2025
Copy link
Contributor

@mutdmour mutdmour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have tests here?

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Feb 14, 2025
Copy link

codecov bot commented Feb 14, 2025

Codecov Report

Attention: Patch coverage is 90.62500% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
packages/editor-ui/src/views/WorkflowsView.vue 93.33% 2 Missing ⚠️
...-ui/src/components/layouts/ResourcesListLayout.vue 50.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@MiloradFilipovic
Copy link
Contributor Author

Can we have tests here?

Sure, will add them.

Copy link
Contributor

✅ All Cypress E2E specs passed

@MiloradFilipovic MiloradFilipovic merged commit d1e65a1 into master Feb 17, 2025
37 checks passed
@MiloradFilipovic MiloradFilipovic deleted the ADO-3233-fix-pagination-prameters-in-url-bug branch February 17, 2025 10:38
@github-actions github-actions bot mentioned this pull request Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants