Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Don't abort import if user already owns credential #14027

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

lure8225
Copy link

Summary

When importing credentials the current implementation fails because it tries to prevent re-owning although the user already owns the credential.

2025-03-18T14:59:46.742Z | error | An error occurred while importing credentials. See log messages for details. {"file":"credentials.js","function":"catch"}
2025-03-18T14:59:46.742Z | error | The credential with ID "3cJ83Qo5X4LKeEqU" is already owned by the user with the ID "b0910508-69e7-4be3-a76d-0c4ceb16d55a". It can't be re-owned by the user with the ID "b0910508-69e7-4be3-a76d-0c4ceb16d55a". {"file":"credentials.js","function":"catch"}

Related Linear tickets, Github issues, and Community forum posts

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • [n/a] Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

Sorry, something went wrong.

@CLAassistant
Copy link

CLAassistant commented Mar 18, 2025

CLA assistant check
All committers have signed the CLA.

@n8n-assistant n8n-assistant bot added community Authored by a community member core Enhancement outside /nodes-base and /editor-ui in linear Issue or PR has been created in Linear for internal review labels Mar 18, 2025
@Joffcom
Copy link
Member

Joffcom commented Mar 18, 2025

Hey @lure8225,

Thanks for the PR, We have created "GHC-1265" as the internal reference to get this reviewed.

One of us will be in touch if there are any changes needed, in most cases this is normally within a couple of weeks but it depends on the current workload of the team.

@netroy netroy changed the title fix(cli): don't abort import if user already owns credential fix(core): don't abort import if user already owns credential Mar 19, 2025
@lure8225 lure8225 changed the title fix(core): don't abort import if user already owns credential fix(core): Don't abort import if user already owns credential Mar 19, 2025
…ct expectation
@lure8225
Copy link
Author

Now properly set up devcontainer which I should have from the start. Tests fixed and passing locally now. Is there a good way to run single tests instead of just running pnpm run test:backend?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Authored by a community member core Enhancement outside /nodes-base and /editor-ui in linear Issue or PR has been created in Linear for internal review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants