feat(editor): Logs overview panel #14045
Open
+817
−107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is 📢 Thoughts on this report? Let us know! |
autologie
commented
Mar 27, 2025
Comment on lines
+448
to
+450
| startedAt: Date | string; | ||
| createdAt: Date | string; | ||
| stoppedAt?: Date | string; |
There was a problem hiding this comment.
Changing type to match the actual behavior (happens when the execution data is received from BE)
| @@ -59,6 +59,7 @@ | |||
| "core-js": "^3.40.0", | |||
| "curlconverter": "^4.12.0", | |||
| "dateformat": "^3.0.3", | |||
| "element-plus": "2.4.3", | |||
There was a problem hiding this comment.
This library has been already in use. I'm adding it as an explicit dependency.
OlegIvaniv
reviewed
Mar 28, 2025
| workflowId, | ||
| data: parse(rawData), | ||
| status, | ||
| startedAt: workflowsStore.workflowExecutionData?.startedAt as Date, |
There was a problem hiding this comment.
Could we do a typeguard here instead of coercing it? Something like:
function ensureDate(value: string | Date | undefined): Date | undefined {
if (!value) return new Date();
if (value instanceof Date) return value;
return new Date(value);
}
| } | ||
|
|
||
| function handleClickToggleButton() { | ||
| props.node.expanded = !props.node.expanded; |
There was a problem hiding this comment.
Could we emit an event here to not mutate the prop directly?
Comment on lines
+45
to
+46
| { label: 'Details', value: 'details' }, | ||
| { label: 'Overview', value: 'overview' }, |
| :icon="props.node.expanded ? 'chevron-down' : 'chevron-up'" | ||
| :style="{ | ||
| visibility: props.data.children.length === 0 ? 'hidden' : '', | ||
| color: 'var(--color-text-base)', |
There was a problem hiding this comment.
Should we put this to toggleButton class? Also perhaps use v-show instead of visibility?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements the new design of logs overview panel behind feature flag.
To try out, set local storage key
N8N_LOGS_2025_SPRINGtotrueand refresh the browser.Note that the logs overview works only for workflows with AI agent node for now.
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/SUG-23/feature-logs-overview-panel
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)