fix(editor): Check for when to show the community+ modal for the folder's feature #14146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RicardoE105
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
RicardoE105
changed the title
RicardoE105
changed the title
CharlieKolb
added
the
release/backport
CharlieKolb
previously approved these changes
Mar 25, 2025
|
|
n8n
|
||||||||||||||||||||||||||||
| Project |
n8n
|
| Branch Review |
fix-check-for-community-plan
|
| Run status |
|
| Run duration | 04m 40s |
| Commit |
|
| Committer | Milorad Filipovic |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
5
|
Skipped
|
0
|
Passing
|
473
|
| View all changes introduced in this branch ↗︎ | |
CharlieKolb
approved these changes
Mar 25, 2025
|
✅ All Cypress E2E specs passed |
RicardoE105
added a commit
that referenced
this pull request
Mar 25, 2025
…er's feature (#14146) Co-authored-by: Milorad Filipovic <[email protected]>
Merged
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We were checking for
usageStore.planName, which is set with the value from GET/license, to determine if the user is on a self hosted deployment, but no matter what the deployment type is we always return planName ascommunity. You can see the check here, that we look for the planName in the license and if not found we default to community.Conclusion its that we are likely not setting the planName as a feature in cloud.
Below a prod trailing instance.
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)