Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Update codecov setup (no-changelog) #9852

Merged
merged 3 commits into from
Jul 3, 2024
Merged

Conversation

netroy
Copy link
Member

@netroy netroy commented Jun 24, 2024

Summary

This PR updates our codecov setup to

  1. Update the github action for code coverage collection
  2. Collect coverage for all packages, without having to maintain an explicit list
  3. Generate valid coverage for @n8n/n8n-nodes-langchain
  4. Collect coverage on master CI only on node.js 20, to prevent hitting rate-limits

Review / Merge checklist

  • PR title and summary are descriptive

@n8n-assistant n8n-assistant bot added the n8n team Authored by the n8n team label Jun 24, 2024
@netroy netroy marked this pull request as draft June 25, 2024 00:35
@netroy netroy marked this pull request as draft June 25, 2024 00:35
@netroy netroy force-pushed the fix-codecov-reporting branch 4 times, most recently from c2af3f9 to db16d71 Compare July 2, 2024 17:57
Copy link

codecov bot commented Jul 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.11%. Comparing base (699a4ae) to head (9d5ae09).
Report is 30 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9852      +/-   ##
==========================================
- Coverage   40.27%   40.11%   -0.16%     
==========================================
  Files        3798     4019     +221     
  Lines      240311   245444    +5133     
  Branches    27672    28444     +772     
==========================================
+ Hits        96781    98462    +1681     
- Misses     141880   145274    +3394     
- Partials     1650     1708      +58     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@netroy netroy marked this pull request as ready for review July 3, 2024 07:39
@netroy netroy changed the title ci: Report coverage to codecov only for node.js 20 (no-changelog) ci: Update codecov setup (no-changelog) Jul 3, 2024
@netroy netroy requested a review from ivov July 3, 2024 08:17
Copy link
Contributor

github-actions bot commented Jul 3, 2024

✅ All Cypress E2E specs passed

Copy link

cypress bot commented Jul 3, 2024

2 flaky tests on run #5752 ↗︎

0 399 0 0 Flakiness 2

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 netroy 🗃️ e2e/*
Project: n8n Commit: 2f0691d0f1
Status: Passed Duration: 04:48 💡
Started: Jul 3, 2024 8:29 AM Ended: Jul 3, 2024 8:34 AM
Flakiness  5-ndv.cy.ts • 1 flaky test

View Output Video

Test Artifacts
NDV > Stop listening for trigger event from NDV Screenshots Video
Flakiness  10-undo-redo.cy.ts • 1 flaky test

View Output Video

Test Artifacts
Undo/Redo > should undo/redo adding connected nodes Test Replay Screenshots Video

Review all test suite changes for PR #9852 ↗︎

@netroy netroy merged commit 962f0d7 into master Jul 3, 2024
27 checks passed
@netroy netroy deleted the fix-codecov-reporting branch July 3, 2024 08:37
@janober
Copy link
Member

janober commented Jul 3, 2024

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants