refactor(editor): Migrate ui.store to use composition API (no-changelog)
#9892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RicardoE105
changed the title
ui.store to composition APIui.store to use composition API (no-changelog)
n8n-assistant
bot
added
n8n team
3 flaky tests on run #5770 ↗︎
Details:
|
||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| NDV > should not retrieve remote options when required params throw errors |
Screenshots
Video
|
|
| NDV > Stop listening for trigger event from NDV |
Screenshots
Video
|
|
10-undo-redo.cy.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| Undo/Redo > should undo/redo adding connected nodes |
Test Replay
Screenshots
Video
|
|
Review all test suite changes for PR #9892 ↗︎
- delete isNodeView computed method as it's not used anymore. - Remove of instances of isAnyModal open as we do not have that method in the store
alexgrozav
requested changes
Jul 1, 2024
alexgrozav
previously approved these changes
Jul 3, 2024
|
|
alexgrozav
approved these changes
Jul 3, 2024
|
✅ All Cypress E2E specs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ui.storeto composition API.isNodeViewandareExpressionsDisabled.isPageLoadingandmainPanelPositionfrom the state as they are not used anymore.Clean up all the uses ofisAnyModalOpenas we do not have that method in the store.@alexgrozav thinking a bit further:
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)