-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Set up env config #17
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea to refactor this 👍 Left couple comments
const ( | ||
// ------------------------ | ||
// auth | ||
// ------------------------ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we could use
// #region auth
...
// #endregion auth
to make these foldable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apparently not supported for Go? https://share.cleanshot.com/5lyhDHfR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I thought I tested it and it worked but seems it only folded the start of the comment :/ Yeah doesn't seem to be supported
Co-authored-by: Tomi Turtiainen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
This PR is setup for runner health monitoring to be done at https://linear.app/n8n/issue/PAY-2280
env
packageN8N_RUNNERS_SERVER_ENABLED
andN8N_RUNNER_URI
to required envs