feat: Use task broker's health endpoint #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Task broker now has a health endpoint, which we can now use. That way we don't need the n8n's api server's URI anymore, simplifying the config.
ivov
reviewed
Nov 27, 2024
| @@ -23,16 +23,16 @@ func sendReadinessRequest(n8nMainServerURI string) (*http.Response, error) { | |||
| return client.Do(req) | |||
| } | |||
|
|
|||
| // CheckUntilN8nReady checks forever until the n8n main instance is ready, i.e. | |||
| // CheckUntilBrokerReady checks forever until the task broker is ready, i.e. | |||
There was a problem hiding this comment.
Suggested change
| // CheckUntilBrokerReady checks forever until the task broker is ready, i.e. | |
| // CheckUntilBrokerReady checks forever until the task broker server is ready, i.e. |
There was a problem hiding this comment.
I don't think we need to repeat the server everywhere. Task broker is a server
Co-authored-by: Iván Ovejero <[email protected]>
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
Co-authored-by: Iván Ovejero <[email protected]>
Co-authored-by: Iván Ovejero <[email protected]>
tomi
deleted the
cat-368-add-healthcheck-endpoint-for-task-broker-and-use-that
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task broker now has a health endpoint, which we can now use. That way we don't need the n8n's api server's URI anymore, simplifying the config.
Related PR: n8n-io/n8n#11920