feat: Add benchmark scope (#7)

* feat: Add benchmark scope The benchmark scope is meant for the benchmark cli. * Add test for valid scopes
n8n-io · Sep 2, 2024 · 8e0184e · 8e0184e
1 parent 5912a17
commit 8e0184e
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/src/constants.js b/src/constants.js
@@ -9,7 +9,7 @@ const TYPES = [
   "ci",
 ];
 
-const SCOPES = ["API", "core", "editor"];
+const SCOPES = ["API", "core", "editor", "benchmark"];
 
 const displayTypes = TYPES.map((type) => `\`${type}\``).join(", ");
 const displayScopes = SCOPES.map((type) => `\`${type}\``).join(", ");

diff --git a/src/validatePrTitle.test.js b/src/validatePrTitle.test.js
@@ -1,5 +1,5 @@
 const { validatePrTitle: validate } = require("./validatePrTitle");
-const { ERRORS, NO_CHANGELOG } = require("./constants");
+const { ERRORS, NO_CHANGELOG, SCOPES } = require("./constants");
 const displayNamesModule = require("./getAllNodesDisplayNames");
 const { TYPES } = require("./constants");
 const {
@@ -98,6 +98,14 @@ describe("scope", () => {
       .toHaveLength(1)
       .toContain(ERRORS.INVALID_SCOPE + ". Did you mean `Gmail Trigger Node`?");
   });
+
+  test.each(SCOPES)(
+    'Validation should pass for valid scope "%s"',
+    async (scope) => {
+      const issues = await validate(`feat(${scope}): Implement feature`);
+      expect(issues).toHaveLength(0);
+    },
+  );
 });
 
 describe("subject", () => {