This repository has been archived by the owner on May 2, 2023. It is now read-only.
temporary fix for /32 CIDR networking issue #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brandon Lum <[email protected]>
Signed-off-by: Brandon Lum <[email protected]>
|
New |
ricarkol
suggested changes
Oct 25, 2018
| // the same subnet... (working on a fix for mask:0) | ||
| cidr := strconv.Itoa(network.MaskCIDR(mask)) | ||
| if cidr == "32" { | ||
| cidr = "1" |
There was a problem hiding this comment.
Add a big warning mentioning that this is happening.
There was a problem hiding this comment.
Ah, I meant a warning("cidr was 32, but will be treated as 1")
Signed-off-by: Brandon Lum <[email protected]>
Signed-off-by: Brandon Lum <[email protected]>
ricarkol
approved these changes
Oct 26, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix by setting mask to "1" if given "32".
To help alleviate #40
Signed-off-by: Brandon Lum [email protected]