Trim dependencies and binary size, add binary docker test #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This gets rid of a few dependencies (including networkx) and adds the --strip option to slim down the total binary size by stripping out debug symbols. This also adds another docker image that uses the linux binary instead of the python wheel to the build. Just making sure the generated binaries actually work now that I'm doing potentially funky stuff to them like stripping out symbols.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gets rid of a few dependencies (including networkx) and adds the --strip option to slim down the total binary size by stripping out debug symbols.
This also adds another docker image that uses the linux binary instead of the python wheel to the build. Just making sure the generated binaries actually work now that I'm doing potentially funky stuff to them like stripping out symbols.