Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new command to delete selected backup increments safely #244

Merged
merged 1 commit into from
May 13, 2024

Conversation

nagyesta
Copy link
Owner

Issue: #190

Description

  • Adds new command to delete selected backup increments
  • Implements parser and properties for the new command
  • Moves increment deletion logic to ManifestManager to make it reusable
  • Implements new controller to take care of increment deletions
  • Adds new tests
  • Updates documentation

Entry point

Checklists

  • I have rebased my branch
  • My commit message is meaningful
  • The commit messages use semantic versioning: {major}, {minor} or {patch}
  • The changes are focusing on the issue at hand
  • I have maintained or increased test coverage

Notes

- Adds new command to delete selected backup increments
- Implements parser and properties for the new command
- Moves increment deletion logic to ManifestManager to make it reusable
- Implements new controller to take care of increment deletions
- Adds new tests
- Updates documentation

Resolves #190
{minor}

Signed-off-by: Esta Nagy <[email protected]>
@nagyesta nagyesta self-assigned this May 13, 2024
@nagyesta nagyesta added the enhancement New feature or request label May 13, 2024
Copy link

codecov bot commented May 13, 2024

Codecov Report

Attention: Patch coverage is 86.53846% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 92.06%. Comparing base (e42635e) to head (cbce604).
Report is 1 commits behind head on main.

Files Patch % Lines
...esta/filebarj/core/common/ManifestManagerImpl.java 78.94% 8 Missing ⚠️
...ebarj/core/delete/IncrementDeletionController.java 72.72% 3 Missing and 3 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #244      +/-   ##
============================================
+ Coverage     91.96%   92.06%   +0.09%     
- Complexity     1123     1145      +22     
============================================
  Files            96       98       +2     
  Lines          3661     3728      +67     
  Branches        251      257       +6     
============================================
+ Hits           3367     3432      +65     
- Misses          214      215       +1     
- Partials         80       81       +1     
Flag Coverage Δ
core 90.68% <77.04%> (+0.02%) ⬆️
job 97.02% <100.00%> (+0.23%) ⬆️
stream 92.16% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nagyesta nagyesta merged commit 5f22dc4 into main May 13, 2024
11 of 12 checks passed
@nagyesta nagyesta deleted the feature/190-delete-backup-increments branch May 13, 2024 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant