Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add progress listeners to the long-running operations #323

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

nagyesta
Copy link
Owner

Issue: #297

Description

  • Defines progress tracker and listener interface
  • Implements progress tracker
  • Implements logging progress listener
  • Fixes log patterns to make logs easier to read
  • Integrates progress tracking into backup, restore, merge, inspect operations
  • Adds new tests
  • Fixes the order of modifiers for the whole codebase
  • Fixes an issue causing incorrect backup type to be reported in case of forced full backups
  • Changes approach for passing input parameters to controllers
  • Defines new parameter VOs with builders
  • Updates tests and documentation

Entry point

Checklists

  • I have rebased my branch
  • My commit message is meaningful
  • The commit messages use semantic versioning: {major}, {minor} or {patch}
  • The changes are focusing on the issue at hand
  • I have maintained or increased test coverage

Notes

Warning

This commit breaks the API. The previous backups should be still fine, the change only affects the Java based use-cases.

@nagyesta nagyesta self-assigned this Aug 23, 2024
@nagyesta nagyesta added the enhancement New feature or request label Aug 23, 2024
@nagyesta nagyesta force-pushed the feature/297-add-progress-listeners branch from 34c5ad4 to 3b6fac7 Compare August 23, 2024 20:48
Copy link

codecov bot commented Aug 23, 2024

Codecov Report

Attention: Patch coverage is 91.80723% with 34 lines in your changes missing coverage. Please review.

Project coverage is 92.05%. Comparing base (a4c2b8c) to head (bf9bff5).
Report is 1 commits behind head on main.

Files Patch % Lines
...barj/core/common/PermissionComparisonStrategy.java 0.00% 0 Missing and 8 partials ⚠️
...ta/filebarj/core/progress/NoOpProgressTracker.java 54.54% 5 Missing ⚠️
...ebarj/core/progress/ObservableProgressTracker.java 93.58% 2 Missing and 3 partials ⚠️
...ebarj/core/backup/pipeline/BaseBackupPipeline.java 70.00% 2 Missing and 1 partial ⚠️
...esta/filebarj/core/common/ManifestManagerImpl.java 92.00% 0 Missing and 2 partials ⚠️
...ithub/nagyesta/filebarj/core/model/BackupPath.java 66.66% 0 Missing and 2 partials ⚠️
...ilebarj/core/restore/pipeline/RestorePipeline.java 95.45% 1 Missing and 1 partial ⚠️
...ilebarj/core/common/ManifestCipherInputStream.java 0.00% 0 Missing and 1 partial ⚠️
...lebarj/core/common/ManifestCipherOutputStream.java 0.00% 0 Missing and 1 partial ⚠️
.../nagyesta/filebarj/core/merge/MergeController.java 95.45% 0 Missing and 1 partial ⚠️
... and 4 more
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #323      +/-   ##
============================================
+ Coverage     92.00%   92.05%   +0.05%     
- Complexity     1168     1208      +40     
============================================
  Files           103      109       +6     
  Lines          3826     4041     +215     
  Branches        262      268       +6     
============================================
+ Hits           3520     3720     +200     
- Misses          222      230       +8     
- Partials         84       91       +7     
Flag Coverage Δ
core 90.82% <90.03%> (+0.09%) ⬆️
job 96.25% <100.00%> (+0.20%) ⬆️
stream 92.30% <97.82%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

- Defines progress tracker and listener interface
- Implements progress tracker
- Implements logging progress listener
- Fixes log patterns to make logs easier to read
- Integrates progress tracking into backup, restore, merge, inspect operations
- Adds new tests
- Fixes the order of modifiers for the whole codebase
- Fixes an issue causing incorrect backup type to be reported in case of forced full backups
- Changes approach for passing input parameters to controllers
- Defines new parameter VOs with builders
- Updates tests and documentation

Resolves #297
{major}

Signed-off-by: Esta Nagy <[email protected]>
@nagyesta nagyesta force-pushed the feature/297-add-progress-listeners branch from 3b6fac7 to bf9bff5 Compare August 23, 2024 21:24
@nagyesta nagyesta merged commit 6bfcfd4 into main Aug 23, 2024
12 checks passed
@nagyesta nagyesta deleted the feature/297-add-progress-listeners branch August 23, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant