Awesome book with ES6 #5
Conversation
There was a problem hiding this comment.
Hi @najibullahjafari ,
Good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!
Highlights
✔️ Good Effort
✔️ Your design is good.
Required Changes ♻️
Check the comments under the review.
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you take them into account as they can make your code better.
[OPTIONAL] Please use a meaningful branch name your branch name is not meaningful. the branch name should be an action or feature like in your case converted-ES6 or ES6 so next time please use a meaningful branch name 🙂
Cheers, and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
index.js
Outdated
| // novelCollection.display.style = 'none'; | ||
| // contactPageSection.display.style = 'none'; |
There was a problem hiding this comment.
[OPTIONAL] Please remove unwanted comments because it's your codebase messy if you want to check your previous code then check your GitHub commit history 🙂
modules/novelCollection.js
Outdated
There was a problem hiding this comment.
- Please use the
arrowfunction instead of the simple function I noticed you use some simple functions. An arrow function expression is a compact alternative to a traditional function expression, with some semantic differences and deliberate limitations in usage: Arrow functions don't have their own bindings to this, arguments, or super, and should not be used as methods. check line no.10,27and34and replace witharrowfunction 🙂
There was a problem hiding this comment.
Hi @najibullahjafari ,
Approved 🟢 🟢
Your project is complete! There is nothing else to say other than... it's time to merge it 
Congratulations! 🎉
Highlights
- App works great💯
- Correct Github flow👍
- Used ES6 arrow functions syntax🟢 👍
Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
In here I brought these chagnes:
1 - I used of ES6
2 - I created modules directory
3 - I used luxon