Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrote unit test for Hilbert transform #164

Merged
merged 4 commits into from
Nov 13, 2024
Merged

Wrote unit test for Hilbert transform #164

merged 4 commits into from
Nov 13, 2024

Conversation

dpaulzc
Copy link
Collaborator

@dpaulzc dpaulzc commented Nov 12, 2024

Moved the Hilbert transform subroutine to misc.f90 and wrote a unit test for the same.

Copy link
Owner

@nakib nakib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Dwaipayan,

Thanks a lot for the PR. I left some comments below. Please resolve all of them.

Best,
Nakib

src/misc.f90 Outdated Show resolved Hide resolved
src/misc.f90 Show resolved Hide resolved
src/misc.f90 Outdated Show resolved Hide resolved
src/misc.f90 Outdated Show resolved Hide resolved
src/misc.f90 Outdated Show resolved Hide resolved
test/test_misc.f90 Outdated Show resolved Hide resolved
test/test_misc.f90 Outdated Show resolved Hide resolved
test/test_misc.f90 Outdated Show resolved Hide resolved
test/test_misc.f90 Outdated Show resolved Hide resolved
test/test_misc.f90 Outdated Show resolved Hide resolved
Copy link
Owner

@nakib nakib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Dwaipayan,

Left my second round of review.

Best,
Nakib

test/test_misc.f90 Outdated Show resolved Hide resolved
src/misc.f90 Outdated Show resolved Hide resolved
src/misc.f90 Outdated Show resolved Hide resolved
test/test_misc.f90 Outdated Show resolved Hide resolved
@nakib nakib merged commit 9bc8620 into prot Nov 13, 2024
2 checks passed
@dpaulzc dpaulzc deleted the paul branch December 6, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants