Skip to content

Commit 8916680

Browse files
committed
fix: update CI to provide revision env var, docs
1 parent 0d44dd0 commit 8916680

File tree

4 files changed

+15
-17
lines changed

4 files changed

+15
-17
lines changed

.github/workflows/release-wallet.yml

Lines changed: 8 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -6,15 +6,12 @@ on:
66
required: true
77
type: string
88
default: "main"
9-
NAMADA_INTERFACE_NAMADA_CHAIN_ID:
10-
required: true
11-
type: string
129

1310
env:
1411
CI: false
1512
jobs:
1613
setup:
17-
runs-on: ubuntu-latest
14+
runs-on: ubuntu-24.04
1815
outputs:
1916
VERSION: ${{ steps.set-environment-variables.outputs.VERSION }}
2017
steps:
@@ -37,7 +34,7 @@ jobs:
3734

3835
build-extension-chrome:
3936
needs: setup
40-
runs-on: ubuntu-latest
37+
runs-on: ubuntu-24.04
4138
steps:
4239
- name: Checkout repository
4340
uses: actions/checkout@v3
@@ -61,9 +58,7 @@ jobs:
6158

6259
- name: Build the extension
6360
working-directory: ./apps/extension
64-
run: yarn build:chrome
65-
env:
66-
NAMADA_INTERFACE_NAMADA_CHAIN_ID: ${{ inputs.NAMADA_INTERFACE_NAMADA_CHAIN_ID }}
61+
run: REVISION=$SHA yarn build:chrome
6762

6863
- uses: actions/upload-artifact@v3
6964
with:
@@ -72,7 +67,7 @@ jobs:
7267

7368
build-extension-firefox:
7469
needs: setup
75-
runs-on: ubuntu-latest
70+
runs-on: ubuntu-24.04
7671
steps:
7772
- name: Checkout repository
7873
uses: actions/checkout@v3
@@ -96,9 +91,7 @@ jobs:
9691

9792
- name: Build the extension
9893
working-directory: ./apps/extension
99-
run: yarn build:firefox
100-
env:
101-
NAMADA_INTERFACE_NAMADA_CHAIN_ID: ${{ inputs.NAMADA_INTERFACE_NAMADA_CHAIN_ID }}
94+
run: REVISION=$SHA yarn build:firefox
10295

10396
- uses: actions/upload-artifact@v3
10497
with:
@@ -107,7 +100,7 @@ jobs:
107100

108101
release:
109102
needs: [setup, build-extension-chrome, build-extension-firefox]
110-
runs-on: ubuntu-latest
103+
runs-on: ubuntu-24.04
111104
steps:
112105
- name: Download Chrome extension build
113106
uses: actions/download-artifact@v3
@@ -129,9 +122,9 @@ jobs:
129122
130123
- name: Make release body text
131124
run: |
132-
echo "NAMADA_INTERFACE_NAMADA_CHAIN_ID: $NAMADA_INTERFACE_NAMADA_CHAIN_ID" >> RELEASE
125+
echo "REVISION: $REVISION" >> RELEASE
133126
env:
134-
NAMADA_INTERFACE_NAMADA_CHAIN_ID: ${{ inputs.NAMADA_INTERFACE_NAMADA_CHAIN_ID }}
127+
REVISION: ${{ github.sha }}
135128

136129
- name: Create release
137130
id: create-release

apps/extension/FIREFOX_README.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,10 @@ yarn wasm:build
4646
Then, issue the final build command for the Firefox add-on:
4747

4848
```bash
49+
# Specify REVISION to match commit in the submitted release build:
4950
export REVISION=487d2a1697f50f06e77677df8e081f868d2a5860
51+
52+
# Build the addon:
5053
yarn build:firefox
5154
```
5255

apps/extension/package.json

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,11 @@
1616
"clean:chrome": "rimraf ./build/chrome",
1717
"clean:firefox": "rimraf ./build/firefox",
1818
"build": "yarn wasm:build && yarn clean && yarn build:chrome && yarn build:firefox",
19-
"build:chrome": "yarn clean:chrome && NODE_ENV=production TARGET=chrome REVISION=$(git rev-parse HEAD) webpack-cli && yarn run web-ext build --s ./build/chrome -a ./build/chrome",
19+
"build:chrome": "yarn clean:chrome && NODE_ENV=production TARGET=chrome webpack-cli && yarn run web-ext build --s ./build/chrome -a ./build/chrome",
20+
"build:chrome:revision": "REVISION=$(git rev-parse HEAD) yarn build:chrome",
2021
"build:chrome:beta": "yarn clean:chrome && NODE_ENV=production BETA_RELEASE=true TARGET=chrome REVISION=$(git rev-parse HEAD) webpack-cli && yarn run web-ext build --s ./build/chrome -a ./build/chrome",
2122
"build:firefox": "yarn clean:firefox && NODE_ENV=production TARGET=firefox webpack-cli && yarn run web-ext build --s ./build/firefox -a ./build/firefox",
23+
"build:firefox:revision": "REVISION=$(git rev-parse HEAD) yarn build:firefox",
2224
"build:firefox:beta": "yarn clean:firefox && NODE_ENV=production BETA_RELEASE=true TARGET=firefox webpack-cli && yarn run web-ext build --s ./build/firefox -a ./build/firefox",
2325
"lint": "eslint src --ext .ts,.tsx",
2426
"lint:fix": "yarn lint -- --fix",

packages/chains/src/chains/namada.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import { BridgeType, Chain, Extensions } from "@namada/types";
22
import { ProxyMappings } from "../types";
33

44
const DEFAULT_ALIAS = "Namada";
5-
const DEFAULT_CHAIN_ID = "public-testnet-15.0dacadb8d663";
5+
const DEFAULT_CHAIN_ID = "namada.5f5de2dd1b88cba30586420";
66
const DEFAULT_RPC = "https://proxy.heliax.click/public-testnet-15.0dacadb8d663";
77
const DEFAULT_BECH32_PREFIX = "tnam";
88

0 commit comments

Comments
 (0)