-
Notifications
You must be signed in to change notification settings - Fork 6
docs: update README & .env.template; fix: persistent Postgres volume … #39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…& webserver healthcheck - README.md: updated installation instructions - .env.template: added an example - persistent postgres volume - webserver: added a curl and healthcheck
| condition: service_healthy | ||
| extra_hosts: | ||
| - "host.docker.internal:host-gateway" | ||
| - "host.docker.internal:host-gateway" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without this, the Crawler doesn't connect to Docker. We have the same for block-index. Tested and verified again.
| - crawler | ||
|
|
||
| healthcheck: | ||
| test: curl --fail http://localhost:5000/health || exit 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
localhost is wrong here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks correct to me. Also, it works fine. We have the same healthcheck in Namada Indexer.
63513c4b49c9 namada-masp-webserver "./webserver" 4 minutes ago Up 24 seconds (healthy) 0.0.0.0:5000->5000/tcp, :::5000->5000/tcp
README.md
Outdated
| - 🔧 - This project is a work in progress. | ||
| - 🚧 - Functionality is not guaranteed at this stage. | ||
| - ⚠️ - Use at your own risk. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove this paragraph
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree. I've also removed this chapter from Namada-Indexer. = Consoicency.
.env.template
Outdated
| @@ -1 +1 @@ | |||
| COMETBFT_URL="" No newline at end of file | |||
| COMETBFT_URL="http://host.docker.internal:26657" No newline at end of file | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just use a placeholder here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree. I've also removed this chapter from Namada-Indexer. = Consoicency.
add the `restart: unless-stopped` policy to have consistency with the `namada-indexer`
…& webserver healthcheck