fix: verify_chain failure on first non-matching root certificate #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tikhop mind taking a look? |
tikhop
changed the title
|
Hi @sinking-point, Apologies for the delay in responding! Thanks again for your contribution! |
|
Hi @sinking-point, Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #60 by continuing to loop through root certificates on signature verification error rather than returning error.
Issue being fixed or feature implemented
#60
How Has This Been Tested?
Added test test_apple_chain_is_valid_multi_root
Breaking Changes
None
Checklist: