ci: format files on commit, validate commit msg

.husky/commit-msg

@@ -0,0 +1 @@
+npx --no -- commitlint --edit $1

.husky/pre-commit

@@ -1 +1 @@
-npm run format:check
+npx lint-staged

commitlint.config.js

@@ -0,0 +1,6 @@
+/**
+ * @type {import('@commitlint/types').UserConfig}
+ */
+module.exports = {
+    extends: ['@commitlint/config-conventional'],
+};

ilc/client/BundleLoader.spec.js

@@ -22,7 +22,6 @@ describe('BundleLoader', () => {
         delete: sinon.stub(),
     };
     let registry;
-    let registryConfigurationStub;
     const configRoot = getIlcConfigRoot();
 
     const mockFactoryFn = () => {};
@@ -54,12 +53,12 @@ describe('BundleLoader', () => {
                 },
             },
         }).getConfig();
-        registryConfigurationStub = sinon.stub(configRoot, 'registryConfiguration').value(registry);
+        sinon.stub(configRoot, 'registryConfiguration').value(registry);
     });
 
     afterEach(() => {
         SystemJs.import.reset();
-        registryConfigurationStub.restore();
+        sinon.stub(configRoot, 'registryConfiguration').restore();
     });
 
     describe('preloadApp()', () => {

ilc/client/Client.js

@@ -268,7 +268,7 @@ export class Client {
     }
 
     #configure() {
-        addNavigationHook((url) => (this.#transitionHooksExecutor.hasAccessTo(url) ? url : null));
+        addNavigationHook((url) => (this.#transitionHooksExecutor.shouldNavigate(url) ? url : null));
         addNavigationHook((url) => this.#urlProcessor.process(url));
 
         // TODO: window.ILC.importLibrary - calls bootstrap function with props (if supported), and returns exposed API

ilc/client/TransitionHooksExecutor.js

@@ -17,7 +17,7 @@ export default class TransitionHooksExecutor {
         this.#logger = logger;
     }
 
-    hasAccessTo(url) {
+    shouldNavigate(url) {
         const route = this.#router.match(url);
         // This code is executed before the router change, so current = previous
         const prevRoute = this.#router.getCurrentRoute();

ilc/client/TransitionHooksExecutor.spec.js

@@ -70,7 +70,7 @@ describe('TransitionHooksExecutor', () => {
 
             const transitionHooksExecutor = new TransitionHooksExecutor(router, pluginManager, errorHandler, logger);
 
-            chai.expect(transitionHooksExecutor.hasAccessTo('/router/does/not/have/route')).to.be.true;
+            chai.expect(transitionHooksExecutor.shouldNavigate('/router/does/not/have/route')).to.be.true;
         });
 
         it(`if none of hooks returns "${actionTypes.stopNavigation}" or "${actionTypes.redirect}" action types`, () => {
@@ -87,7 +87,7 @@ describe('TransitionHooksExecutor', () => {
 
             const transitionHooksExecutor = new TransitionHooksExecutor(router, pluginManager, errorHandler, logger);
 
-            chai.expect(transitionHooksExecutor.hasAccessTo(url)).to.be.true;
+            chai.expect(transitionHooksExecutor.shouldNavigate(url)).to.be.true;
 
             for (const hook of hooks) {
                 sinon.assert.calledOnceWithExactly(hook, {
@@ -115,7 +115,7 @@ describe('TransitionHooksExecutor', () => {
 
             const transitionHooksExecutor = new TransitionHooksExecutor(router, pluginManager, errorHandler, logger);
 
-            chai.expect(transitionHooksExecutor.hasAccessTo(url)).to.be.false;
+            chai.expect(transitionHooksExecutor.shouldNavigate(url)).to.be.false;
             sinon.assert.calledOnce(errorHandler);
             chai.expect(errorHandler.getCall(0).args[0]).to.have.property('cause', error);
             chai.expect(errorHandler.getCall(0).args[0]).to.be.instanceOf(TransitionHookError);
@@ -152,7 +152,7 @@ describe('TransitionHooksExecutor', () => {
 
             const transitionHooksExecutor = new TransitionHooksExecutor(router, pluginManager, errorHandler, logger);
 
-            chai.expect(transitionHooksExecutor.hasAccessTo(url)).to.be.false;
+            chai.expect(transitionHooksExecutor.shouldNavigate(url)).to.be.false;
             sinon.assert.calledOnceWithExactly(
                 logger.info,
                 `ILC: Stopped navigation due to the Route Guard with index #${1}`,
@@ -185,7 +185,7 @@ describe('TransitionHooksExecutor', () => {
 
             const transitionHooksExecutor = new TransitionHooksExecutor(router, pluginManager, errorHandler, logger);
 
-            chai.expect(transitionHooksExecutor.hasAccessTo(url)).to.be.false;
+            chai.expect(transitionHooksExecutor.shouldNavigate(url)).to.be.false;
             sinon.assert.notCalled(router.navigateToUrl);
 
             for (const hook of [hooks[0], hooks[1]]) {

lint-staged.config.js

@@ -0,0 +1,6 @@
+/**
+ * @type {import('lint-staged').Config}
+ */
+module.exports = {
+    '*': 'prettier --ignore-unknown --write',
+};