fix: save visited url on scroll on every navigation rather than on specific transition.

ilc/client/TransitionManager/ScrollController/ScrollController.js

@@ -9,9 +9,12 @@ export class ScrollController {
         return window.location;
     }
 
-    store() {
+    onEveryRouteChange() {
         this.#shouldScrollToTop = this.#lastVisitedUrl.toLowerCase() !== this.location.pathname.toLowerCase();
         this.#lastVisitedUrl = this.location.pathname;
+    }
+
+    store() {
         if (this.location.hash) {
             const node = this.#hashStoreNode;
             const hashValue = this.#getHashValue();

ilc/client/TransitionManager/ScrollController/ScrollController.spec.js

@@ -79,8 +79,8 @@ describe('ScrollController', () => {
 
         it('should not scroll to top if store has recorded navigation between the same path', () => {
             scrollSpy = sinon.spy(window, 'scroll');
-            scrollController.store();
-            scrollController.store();
+            scrollController.onEveryRouteChange();
+            scrollController.onEveryRouteChange();
 
             scrollController.restore();
 

ilc/client/TransitionManager/TransitionManager.js

@@ -264,14 +264,16 @@ export class TransitionManager {
     };
 
     #onRouteChange = () => {
-        if (this.#transitionBlockers.isEmpty()) {
-            this.#onPageReady();
+        if (!this.#transitionBlockers.isEmpty()) {
+            return;
+        }
 
-            if (!this.#transitionBlockers.isReady()) {
-                this.#transitionBlockers.init();
-                // ilcEvents.ALL_SLOTS_LOADED is dispatched only on first page load here
-                window.dispatchEvent(new CustomEvent(ilcEvents.ALL_SLOTS_LOADED));
-            }
+        this.#scrollController.onEveryRouteChange();
+        this.#onPageReady();
+        if (!this.#transitionBlockers.isReady()) {
+            this.#transitionBlockers.init();
+            // ilcEvents.ALL_SLOTS_LOADED is dispatched only on first page load here
+            window.dispatchEvent(new CustomEvent(ilcEvents.ALL_SLOTS_LOADED));
         }
     };
 }

registry/server/templates/services/resources/Resource.ts

@@ -18,10 +18,7 @@ export abstract class Resource {
         ...Attributes.crossorigin,
     };
 
-    constructor(
-        public uri: string,
-        params?: Params,
-    ) {
+    constructor(public uri: string, params?: Params) {
         this.params = params || {};
     }
 

registry/server/templates/services/templatesRepository.ts

@@ -14,13 +14,10 @@ export async function readTemplateWithAllVersions(templateName: string) {
         .select()
         .from<LocalizedTemplate>(tables.templatesLocalized)
         .where('templateName', templateName);
-    template.localizedVersions = localizedTemplates.reduce(
-        (acc, item) => {
-            acc[item.locale] = { content: item.content };
-            return acc;
-        },
-        {} as Record<string, object>,
-    );
+    template.localizedVersions = localizedTemplates.reduce((acc, item) => {
+        acc[item.locale] = { content: item.content };
+        return acc;
+    }, {} as Record<string, object>);
 
     return template;
 }