Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace v3 onion bootstrap seeds with valid Namecoin full nodes #495

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ss11s
Copy link

@ss11s ss11s commented Mar 7, 2022

Some manually added reliable v3 onion Namecoin MainNet full nodes to help initial Tor bootstrapping.

@domob1812
Copy link

@JeremyRand what do you think about this change? I believe you updated the seed nodes list last (but maybe I misremember).

@ss11s
Copy link
Author

ss11s commented Mar 8, 2022

@JeremyRand This makes sense yes, you are correct. Addressed in 644e79f

@ss11s
Copy link
Author

ss11s commented Mar 8, 2022

@JeremyRand what do you think about this change? I believe you updated the seed nodes list last (but maybe I misremember).

The way I see that list has been updated by @JeremyRand recently (December 2021) and while of course no node is guaranteed to be stable all the time there are plenty of node addresses there and a big % should work. I can open a PR for that as well and put all the IP addresses reported by my dnsseeds, if you think it's useful.

@JeremyRand
Copy link
Member

ACK 319b0a5

@domob1812
Copy link

ACK from me as well. @ss11s Please squash all commits into a single one, then we can merge it.

Fix the additional leading empty spaces, reverse to the original date and added TODO lines so it's clear that these networks are supported and stable nodes there are welcomed.

Replace with valid Namecoin full nodes

Some manually added reliable v3 onion NMC full nodes to help initial Tor bootstrapping.

Add comments for i2p and cjdns as they are supported

Allowing these comments as suggested, so it's known that i2p and cjdns networks are supported as well, so peers can/could be in these networks as well.

Fix typo

Fix date typo.
@ss11s
Copy link
Author

ss11s commented Aug 29, 2022

@domob1812 done. sorry for delay.

@domob1812
Copy link

Thanks. Please resolve the conflicts as well.

Also - I've myself so far only worked with the nodes_main.txt file (that then gets used to create chainparamsseeds.h). What exactly is the "manual" file used for? Should we also update some other generated files with it or something?

@ss11s
Copy link
Author

ss11s commented Sep 28, 2022

@domob1812 done. is there any other place we need to replace BTC nodes with valid NMC nodes? By looking at our upstream I only identified this file.

@ss11s
Copy link
Author

ss11s commented Dec 29, 2022

@domob1812 is there anything more we need to do here? Getting back on this as I recently got an email from an user that was unable to bootstrap to the network with a node used in onlynet=onion mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants