fix(ci): merge docker build & push #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This one allows saving a lot of space on the GitHub Action runtime and avoid "no space left on the device" error.
tk-o
commented
Jan 30, 2025
| env: | ||
| IMAGE_NAME: ghcr.io/${{ github.repository }}/ensrainbow | ||
| TAG: ${{ github.ref == 'refs/heads/main' && 'latest' || github.ref == 'refs/heads/alpha' && 'alpha' || github.ref == 'refs/heads/subgraph' && 'subgraph' }} | ||
| run: | | ||
| echo ${{ secrets.GITHUB_TOKEN }} | docker login ghcr.io -u ${{ github.actor }} --password-stdin | ||
| docker build -f apps/ensrainbow/Dockerfile -t $IMAGE_NAME:$TAG -t $IMAGE_NAME:${{ github.sha }} . | ||
| docker save $IMAGE_NAME:$TAG $IMAGE_NAME:${{ github.sha }} > image.tar |
There was a problem hiding this comment.
This one was causing the "no space left on device" error, as it was effectively doubling the 7GB file.
djstrong
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one allows saving a lot of space on the GitHub Action runtime and avoid "no space left on the device" error. Before this change, there would be separate steps for building Docker image, and for pushing it to container registry. It would require a temp file to be saved and shared between those files. This temp file was too large to fit on the available storage space.
Error: