Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugin-helpers): plugin activation #35

Merged
merged 1 commit into from
Jan 20, 2025
Merged

Conversation

tk-o
Copy link
Contributor

@tk-o tk-o commented Jan 20, 2025

Check all constraints before activating a given available plugin. Before, all available plugins would get activated, which was an unintended behaviour.

Check all constraints before activiating a given requested plugin. Before, all requested plugins would get activated, which was an uninteded behaviour.
Copy link
Member

@lightwalker-eth lightwalker-eth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tk-o Looks good 👍 Thanks

@lightwalker-eth lightwalker-eth merged commit d38920a into main Jan 20, 2025
1 check passed
@lightwalker-eth lightwalker-eth deleted the fix/active-plugins branch January 21, 2025 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants