WIP: Polymorphic Config + Resolution #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…p so typechecking fallthrough uses same tsconfig
tk-o
reviewed
Jan 28, 2025
| }, | ||
| }, | ||
| }), | ||
| ); |
tk-o
reviewed
Jan 28, 2025
Comment on lines
+238
to
+244
| // NOTE: this actually produces a bug in the subgraph's graphql layer — `resolver` is not nullable | ||
| // but there is never a resolver record created for the zeroAddress. so if you query the | ||
| // `resolver { id }` of a NewResolver event that set the resolver to zeroAddress | ||
| // ex: newResolver(id: "3745840-2") { id resolver {id} } | ||
| // you will receive a GraphQL type error. for subgraph compatibility we re-implement this | ||
| // behavior here, but it should be entirely avoided in a v2 restructuring of the schema. | ||
| resolverId: resolverAddress === zeroAddress ? zeroAddress : resolverId, |
tk-o
reviewed
Jan 28, 2025
| // simplifies generating the shared event column values from the ponder Event object | ||
| export function sharedEventValues(event: Omit<Event, "args">) { | ||
| return { | ||
| id: makeEventId(event.block.number, event.log.logIndex), |
lightwalker-eth
approved these changes
Jan 28, 2025
There was a problem hiding this comment.
@shrugs Hahah, this is nuts 😅 Amazing work 💪
| const id = makeResolverId(event.log.address, node); | ||
| const resolver = await upsertResolver(context, { | ||
|
|
||
| // upsert resolveer |
There was a problem hiding this comment.
Suggested change
| // upsert resolveer | |
| // upsert resolver |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #64 and #65
executePluralQueryto support subquery selectiontodo
4_000_000hardcodeensnodesubproject using its more strict tsconfig against the code inponder-subgraph-api.