Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not fail Vault provider on optional secrets. #1355

Merged
merged 2 commits into from
Nov 25, 2024
Merged

Do not fail Vault provider on optional secrets. #1355

merged 2 commits into from
Nov 25, 2024

Conversation

n-g
Copy link
Contributor

@n-g n-g commented Nov 25, 2024

Towards NSL-4690

@n-g n-g requested a review from edganiukov November 25, 2024 16:23
@n-g n-g enabled auto-merge November 25, 2024 16:25
@n-g n-g disabled auto-merge November 25, 2024 16:26
@n-g n-g enabled auto-merge November 25, 2024 16:36
@n-g n-g added this pull request to the merge queue Nov 25, 2024
Merged via the queue into main with commit aea3a9a Nov 25, 2024
18 checks passed
@n-g n-g deleted the niklas-support-optional branch November 25, 2024 16:41
edganiukov
edganiukov reviewed Nov 26, 2024
View reviewed changes
Copy link
Contributor

@edganiukov edganiukov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice 👍
lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edganiukov edganiukov edganiukov left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@n-g @edganiukov