Skip to content

Commit

Permalink
build: Add -mno-sse for x86_64 build
Browse files Browse the repository at this point in the history
It was reported that using -mno-sse2 alone can crash clang compiler when
the code it compiles accesses floating-point or vector types.  It seems
adding -mno-sse fix the problem.  I thought -mno-sse2 implies it but
that doesn't seem like the case and caused a problem.

Actually recent versions of clang have -mgeneral-regs-only option and we
should prefer it.  But let's keep the fix minimal for now.

Signed-off-by: Namhyung Kim <[email protected]>
  • Loading branch information
namhyung committed Jan 12, 2024
1 parent 139e3f7 commit 95cb111
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion check-deps/Makefile.check
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ ifneq ($(wildcard $(objdir)/check-deps/cxa_demangle),)
endif

ifneq ($(wildcard $(objdir)/check-deps/cc_has_mno_sse2),)
LIB_CFLAGS += -mno-sse2
LIB_CFLAGS += -mno-sse -mno-sse2
endif

ifneq ($(wildcard $(objdir)/check-deps/have_libpython3),)
Expand Down

0 comments on commit 95cb111

Please sign in to comment.