error: docs for function returning `Result` missing `# Errors` section --> src/token/mod.rs:288:5 | 288 | / fn sign( 289 | | key: &CoseKey, 290 | | target: &[u8], 291 | | unprotected_header: &Header, 292 | | protected_header: &Header, 293 | | ) -> Result<Vec<u8>, CoseCipherError<Self::Error>>; | |_______________________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc = note: `#[deny(clippy::missing_errors_doc)]` implied by `#[deny(clippy::pedantic)]`

you seem to be trying to match on a boolean expression: src/token/crypto_impl/openssl.rs#L358

error: you seem to be trying to match on a boolean expression --> src/token/crypto_impl/openssl.rs:358:57 | 358 | .and_then(|verification_successful| match verification_successful { | _________________________________________________________^ 359 | | true => Ok(()), 360 | | false => Err(CoseCipherError::VerificationFailure), 361 | | }) | |_____________________^ help: consider using an `if`/`else` expression: `if verification_successful { Ok(()) } else { Err(CoseCipherError::VerificationFailure) }` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool = note: `#[deny(clippy::match_bool)]` implied by `#[deny(clippy::pedantic)]`

explicit `deref` method call: src/token/crypto_impl/openssl.rs#L284

error: explicit `deref` method call --> src/token/crypto_impl/openssl.rs:284:21 | 284 | / PKey::from_ec_key(private_key) 285 | | .map_err(CoseOpensslCipherError::from)? 286 | | .deref(), | |________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_deref_methods = note: `#[deny(clippy::explicit_deref_methods)]` implied by `#[deny(clippy::pedantic)]` help: try | 284 ~ &*PKey::from_ec_key(private_key) 285 ~ .map_err(CoseOpensslCipherError::from)?, |

this function has too many lines (119/100): src/token/crypto_impl/openssl.rs#L111

error: this function has too many lines (119/100) --> src/token/crypto_impl/openssl.rs:111:5 | 111 | / fn set_headers<RNG: RngCore + CryptoRng>( 112 | | key: &CoseKey, 113 | | unprotected_header: &mut Header, 114 | | protected_header: &mut Header, ... | 260 | | } 261 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_lines note: the lint level is defined here --> src/lib.rs:307:42 | 307 | #![deny(rustdoc::broken_intra_doc_links, clippy::pedantic)] | ^^^^^^^^^^^^^^^^ = note: `#[deny(clippy::too_many_lines)]` implied by `#[deny(clippy::pedantic)]`

clippy_check

Clippy had exited with the 101 exit code

Test Suite

The process '/home/runner/.cargo/bin/cargo' failed with exit code 101

test_coverage

test failed, to rerun pass `--lib`

test_coverage

1 target failed:

test_coverage

The process '/home/runner/.cargo/bin/cargo' failed with exit code 101

Rustfmt

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v2, actions-rs/toolchain@v1, actions-rs/cargo@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

Rustfmt

The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

Rustfmt

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Rustfmt

missing documentation for a variant: src/token/crypto_impl/openssl.rs#L53

warning: missing documentation for a variant --> src/token/crypto_impl/openssl.rs:53:5 | 53 | Other(&'static str), | ^^^^^

missing documentation for a variant: src/token/crypto_impl/openssl.rs#L52

warning: missing documentation for a variant --> src/token/crypto_impl/openssl.rs:52:5 | 52 | TypeMismatch(Value), | ^^^^^^^^^^^^

missing documentation for a variant: src/token/crypto_impl/openssl.rs#L51

warning: missing documentation for a variant --> src/token/crypto_impl/openssl.rs:51:5 | 51 | OpensslError(core::ffi::c_ulong), | ^^^^^^^^^^^^

missing documentation for a variant: src/token/crypto_impl/openssl.rs#L48

warning: missing documentation for a variant --> src/token/crypto_impl/openssl.rs:48:5 | 48 | MissingEc2KeyParam(iana::Ec2KeyParameter), | ^^^^^^^^^^^^^^^^^^

missing documentation for a variant: src/token/crypto_impl/openssl.rs#L47

warning: missing documentation for a variant --> src/token/crypto_impl/openssl.rs:47:5 | 47 | MissingKeyParam(iana::KeyParameter), | ^^^^^^^^^^^^^^^

missing documentation for a variant: src/token/crypto_impl/openssl.rs#L46

warning: missing documentation for a variant --> src/token/crypto_impl/openssl.rs:46:5 | 46 | InvalidKeyId(Vec<u8>), | ^^^^^^^^^^^^

missing documentation for a variant: src/token/crypto_impl/openssl.rs#L45

warning: missing documentation for a variant --> src/token/crypto_impl/openssl.rs:45:5 | 45 | DuplicateHeaders(Vec<Label>), | ^^^^^^^^^^^^^^^^

missing documentation for a variant: src/token/crypto_impl/openssl.rs#L44

warning: missing documentation for a variant --> src/token/crypto_impl/openssl.rs:44:5 | 44 | KeyTypeCurveMismatch(KeyType, iana::EllipticCurve), | ^^^^^^^^^^^^^^^^^^^^

missing documentation for a variant: src/token/crypto_impl/openssl.rs#L43

warning: missing documentation for a variant --> src/token/crypto_impl/openssl.rs:43:5 | 43 | KeyTypeAlgorithmMismatch(KeyType, Algorithm), | ^^^^^^^^^^^^^^^^^^^^^^^^

missing documentation for a variant: src/token/crypto_impl/openssl.rs#L42

warning: missing documentation for a variant --> src/token/crypto_impl/openssl.rs:42:5 | 42 | UnsupportedKeyOperation(iana::KeyOperation), | ^^^^^^^^^^^^^^^^^^^^^^^

missing documentation for a variant: src/token/crypto_impl/openssl.rs#L41

warning: missing documentation for a variant --> src/token/crypto_impl/openssl.rs:41:5 | 41 | UnsupportedAlgorithm(Algorithm), | ^^^^^^^^^^^^^^^^^^^^

missing documentation for a variant: src/token/crypto_impl/openssl.rs#L40

warning: missing documentation for a variant --> src/token/crypto_impl/openssl.rs:40:5 | 40 | UnsupportedCurve(Option<iana::EllipticCurve>), | ^^^^^^^^^^^^^^^^

missing documentation for a variant: src/token/crypto_impl/openssl.rs#L39

warning: missing documentation for a variant --> src/token/crypto_impl/openssl.rs:39:5 | 39 | UnsupportedKeyType, | ^^^^^^^^^^^^^^^^^^

missing documentation for an enum: src/token/crypto_impl/openssl.rs#L38

warning: missing documentation for an enum --> src/token/crypto_impl/openssl.rs:38:1 | 38 | pub enum CoseOpensslCipherError { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

missing documentation for a module: src/token/crypto_impl/mod.rs#L17

warning: missing documentation for a module --> src/token/crypto_impl/mod.rs:17:1 | 17 | pub mod openssl; | ^^^^^^^^^^^^^^^ | note: the lint level is defined here --> src/lib.rs:308:9 | 308 | #![warn(missing_docs, rustdoc::missing_crate_level_docs)] | ^^^^^^^^^^^^

this expression creates a reference which is immediately dereferenced by the compiler: src/token/crypto_impl/openssl.rs#L415

warning: this expression creates a reference which is immediately dereferenced by the compiler --> src/token/crypto_impl/openssl.rs:415:9 | 415 | / &BigNum::from_slice(y) 416 | | .map_err(CoseOpensslCipherError::from)? 417 | | .deref(), | |____________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow help: change this to | 415 ~ BigNum::from_slice(y) 416 + .map_err(CoseOpensslCipherError::from)? 417 ~ .deref(), |

this expression creates a reference which is immediately dereferenced by the compiler: src/token/crypto_impl/openssl.rs#L412

warning: this expression creates a reference which is immediately dereferenced by the compiler --> src/token/crypto_impl/openssl.rs:412:9 | 412 | / &BigNum::from_slice(x) 413 | | .map_err(CoseOpensslCipherError::from)? 414 | | .deref(), | |____________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow help: change this to | 412 ~ BigNum::from_slice(x) 413 + .map_err(CoseOpensslCipherError::from)? 414 ~ .deref(), |

this expression creates a reference which is immediately dereferenced by the compiler: src/token/crypto_impl/openssl.rs#L411

warning: this expression creates a reference which is immediately dereferenced by the compiler --> src/token/crypto_impl/openssl.rs:411:9 | 411 | &group, | ^^^^^^ help: change this to: `group` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

called `map(..).flatten()` on `Option`: src/token/crypto_impl/openssl.rs#L404

warning: called `map(..).flatten()` on `Option` --> src/token/crypto_impl/openssl.rs:404:10 | 404 | .map(Value::as_bytes) | __________^ 405 | | .flatten() | |__________________^ help: try replacing `map` with `and_then` and remove the `.flatten()`: `and_then(Value::as_bytes)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten

called `map(..).flatten()` on `Option`: src/token/crypto_impl/openssl.rs#L398

warning: called `map(..).flatten()` on `Option` --> src/token/crypto_impl/openssl.rs:398:10 | 398 | .map(Value::as_bytes) | __________^ 399 | | .flatten() | |__________________^ help: try replacing `map` with `and_then` and remove the `.flatten()`: `and_then(Value::as_bytes)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten

this expression creates a reference which is immediately dereferenced by the compiler: src/token/crypto_impl/openssl.rs#L383

warning: this expression creates a reference which is immediately dereferenced by the compiler --> src/token/crypto_impl/openssl.rs:383:9 | 383 | / &BigNum::from_slice(d) 384 | | .map_err(CoseOpensslCipherError::from)? 385 | | .deref(), | |____________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `#[warn(clippy::needless_borrow)]` on by default help: change this to | 383 ~ BigNum::from_slice(d) 384 + .map_err(CoseOpensslCipherError::from)? 385 ~ .deref(), |

called `map(..).flatten()` on `Option`: src/token/crypto_impl/openssl.rs#L375

warning: called `map(..).flatten()` on `Option` --> src/token/crypto_impl/openssl.rs:375:10 | 375 | .map(Value::as_bytes) | __________^ 376 | | .flatten() | |__________________^ help: try replacing `map` with `and_then` and remove the `.flatten()`: `and_then(Value::as_bytes)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten = note: `#[warn(clippy::map_flatten)]` on by default

assigning the result of `Clone::clone()` may be inefficient: src/token/crypto_impl/openssl.rs#L253

warning: assigning the result of `Clone::clone()` may be inefficient --> src/token/crypto_impl/openssl.rs:253:21 | 253 | unprotected_header.key_id = key.key_id.clone(); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_from()`: `unprotected_header.key_id.clone_from(&key.key_id)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones = note: `#[warn(clippy::assigning_clones)]` on by default

using `clone` on type `EllipticCurve` which implements the `Copy` trait: src/token/crypto_impl/openssl.rs#L180

warning: using `clone` on type `EllipticCurve` which implements the `Copy` trait --> src/token/crypto_impl/openssl.rs:180:33 | 180 | ... v.clone(), | ^^^^^^^^^ help: try removing the `clone` call: `v` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy = note: `#[warn(clippy::clone_on_copy)]` on by default

you are explicitly cloning with `.map()`: src/token/crypto_impl/openssl.rs#L125

warning: you are explicitly cloning with `.map()` --> src/token/crypto_impl/openssl.rs:125:21 | 125 | / duplicate_header_fields 126 | | .into_iter() 127 | | .map(Label::clone) | |__________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone = note: `#[warn(clippy::map_clone)]` on by default help: consider calling the dedicated `cloned` method | 125 ~ duplicate_header_fields 126 + .into_iter().cloned() |

writing `&Vec` instead of `&[_]` involves a new object where a slice will do: src/token/crypto_impl/openssl.rs#L98

warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do --> src/token/crypto_impl/openssl.rs:98:54 | 98 | fn find_param_by_label<'a>(label: &Label, param_vec: &'a Vec<(Label, Value)>) -> Option<&'a Value> { | ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&'a [(Label, Value)]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg = note: `#[warn(clippy::ptr_arg)]` on by default

unneeded `return` statement: src/token/crypto_impl/openssl.rs#L95

warning: unneeded `return` statement --> src/token/crypto_impl/openssl.rs:95:5 | 95 | return header_bucket_fields; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return = note: `#[warn(clippy::needless_return)]` on by default help: remove `return` | 95 - return header_bucket_fields; 95 + header_bucket_fields |

unused variable: `protected_signature_header`: src/token/crypto_impl/openssl.rs#L326

warning: unused variable: `protected_signature_header` --> src/token/crypto_impl/openssl.rs:326:9 | 326 | protected_signature_header: Option<&ProtectedHeader>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_protected_signature_header`

unused variable: `unprotected_signature_header`: src/token/crypto_impl/openssl.rs#L325

warning: unused variable: `unprotected_signature_header` --> src/token/crypto_impl/openssl.rs:325:9 | 325 | unprotected_signature_header: Option<&Header>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_unprotected_signature_header`

variable does not need to be mutable: src/token/crypto_impl/openssl.rs#L204

warning: variable does not need to be mutable --> src/token/crypto_impl/openssl.rs:204:21 | 204 | let mut algorithm = match algorithm { | ----^^^^^^^^^ | | | help: remove this `mut` | = note: `#[warn(unused_mut)]` on by default

unused variable: `e`: src/token/crypto_impl/openssl.rs#L161

warning: unused variable: `e` --> src/token/crypto_impl/openssl.rs:161:47 | 161 | i64::try_from(v).map_err(|e| { | ^ help: if this is intentional, prefix it with an underscore: `_e` | = note: `#[warn(unused_variables)]` on by default

unused import: `CoseKeyBuilder`: src/token/crypto_impl/openssl.rs#L22

warning: unused import: `CoseKeyBuilder` --> src/token/crypto_impl/openssl.rs:22:31 | 22 | iana, Algorithm, CoseKey, CoseKeyBuilder, Header, KeyType, Label, ProtectedHeader, | ^^^^^^^^^^^^^^

unused import: `Integer`: src/token/crypto_impl/openssl.rs#L18

warning: unused import: `Integer` --> src/token/crypto_impl/openssl.rs:18:23 | 18 | use ciborium::value::{Integer, Value}; | ^^^^^^^ | = note: `#[warn(unused_imports)]` on by default

clippy_check

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v2, actions-rs/clippy-check@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

clippy_check

The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

Check (no_std)

Check

Check: src/token/crypto_impl/openssl.rs#L18

unused import: `Integer`

Check: src/token/crypto_impl/openssl.rs#L22

unused import: `CoseKeyBuilder`

Check: src/token/crypto_impl/openssl.rs#L161

unused variable: `e`

Check: src/token/crypto_impl/openssl.rs#L204

variable does not need to be mutable

Check: src/token/crypto_impl/openssl.rs#L325

unused variable: `unprotected_signature_header`

Check: src/token/crypto_impl/openssl.rs#L326

unused variable: `protected_signature_header`

Check: src/token/crypto_impl/mod.rs#L17

missing documentation for a module

Check: src/token/crypto_impl/openssl.rs#L38

missing documentation for an enum

Check: src/token/crypto_impl/openssl.rs#L39

missing documentation for a variant

Check: src/token/crypto_impl/openssl.rs#L40

missing documentation for a variant

Check

Test Suite

Test Suite: src/token/crypto_impl/openssl.rs#L18

unused import: `Integer`

Test Suite: src/token/crypto_impl/openssl.rs#L22

unused import: `CoseKeyBuilder`

Test Suite: src/token/crypto_impl/openssl.rs#L161

unused variable: `e`

Test Suite: src/token/crypto_impl/openssl.rs#L204

variable does not need to be mutable

Test Suite: src/token/crypto_impl/openssl.rs#L325

unused variable: `unprotected_signature_header`

Test Suite: src/token/crypto_impl/openssl.rs#L326

unused variable: `protected_signature_header`

Test Suite: src/token/crypto_impl/openssl.rs#L431

unused import: `Verifier`

Test Suite: src/token/crypto_impl/openssl.rs#L432

unused import: `serde::Serialize`

Test Suite: src/token/crypto_impl/mod.rs#L17

missing documentation for a module

Test Suite: src/token/crypto_impl/openssl.rs#L38

missing documentation for an enum

test_coverage

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions-rs/toolchain@v1, actions-rs/cargo@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

test_coverage

The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

test_coverage: src/token/crypto_impl/openssl.rs#L18

unused import: `Integer`

test_coverage: src/token/crypto_impl/openssl.rs#L22

unused import: `CoseKeyBuilder`

test_coverage: src/token/crypto_impl/openssl.rs#L161

unused variable: `e`

test_coverage: src/token/crypto_impl/openssl.rs#L204

variable does not need to be mutable

test_coverage: src/token/crypto_impl/openssl.rs#L325

unused variable: `unprotected_signature_header`