Bugfix/add custom_lint_core dependency and import it #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #90 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 20 20
Lines 1166 1166
=========================================
Hits 1166 1166 |
|
Does it work now? |
|
Yes, it works now :) I tested it with a However, it works for me only if I temporarily comment out some packages in my pubspec.yaml (in my case they are The Note: The issue I just brought up is not introduced by this PR. It was already present before. |
|
Since it is actually a separate issue I opened #91 and we can continue the conversation there. |
|
Hey there, rm pubspec.lock
flutter clean
flutter pub get
dart run custom_lintBefore doing this delete the |
|
I just tried by cloning your current Also, the language server detects the problem anyway:
Which is the same error pub.dev detects. This PR will definitely fix this bug. |
|
The |
|
So, I don't know why you are not experiencing the conflict, but there definitely is one. There is probably an even better way to solve this: let's change the import in the lint files from:
to
This way we can remove the extra dependency and the extra import. I'll soon create another commit and push it. |
|
I still don't know why the issue doesn't happen in my machine, maybe I have something cached. |
nank1ro
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dart run custom_lintdoes not run successfully due to import collision of theanalyzerandcustom_lint_corepackages. They both have aLintCodeclass, but only thecustom_lint_coreis the one thatsolidart_lintdirectly uses.You can also see the package doesn't pass the static analysis at the moment (https://pub.dev/packages/solidart_lint/score).