Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Stream<T> non-nullable #96

Closed

Conversation

manuel-plavsic
Copy link
Collaborator

final Stream<T>? Function()? stream; was probability meant to be final Stream<T> Function()? stream;

Copy link

codecov bot commented Dec 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (91dc6b3) to head (fb4cce4).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               dev       #96   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           21        21           
  Lines         1191      1191           
=========================================
  Hits          1191      1191           
Files with missing lines Coverage Δ
packages/solidart/lib/src/core/resource.dart 100.00% <100.00%> (ø)

Copy link
Owner

@nank1ro nank1ro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nank1ro
Copy link
Owner

nank1ro commented Dec 30, 2024

closing this in favor of #97

@nank1ro nank1ro closed this Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants