Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chore] Replace deprecated methods of ErrorReporter #98

Conversation

manuel-plavsic
Copy link
Collaborator

I just replaced the deprecated methods.

@nank1ro
Copy link
Owner

nank1ro commented Dec 29, 2024

Are you using the latest stable of Flutter?

@manuel-plavsic
Copy link
Collaborator Author

The latest main:

> flutter --version
Flutter 3.28.0-2.0.pre.38587 • channel main • https://github.com/flutter/flutter.git
Framework • revision b15625ca92 (35 hours ago) • 2024-12-27 15:26:24 -0800
Engine • revision b15625ca92
Tools • Dart 3.7.0 (build 3.7.0-267.0.dev) • DevTools 2.41.0

@manuel-plavsic
Copy link
Collaborator Author

I probably should test if the changes work also with master, same for the other branch

@nank1ro
Copy link
Owner

nank1ro commented Dec 29, 2024

I probably should test if the changes work also with master, same for the other branch

See #99 (comment)

Copy link
Owner

@nank1ro nank1ro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nank1ro nank1ro merged commit c2c53ed into nank1ro:dev Dec 30, 2024
1 check passed
Copy link

codecov bot commented Dec 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (3358c62) to head (6bb7ef0).
Report is 2 commits behind head on dev.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               dev       #98   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           21        21           
  Lines         1194      1194           
=========================================
  Hits          1194      1194           

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants