Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because we weren't creating a default window in
WindowPlugin
, the renderer wasn't able to initialize with the correct surface to attach to the canvas. This PR fixes this by doing some hacks when compiling underwasm32
to create the default window and then update it to whatever the user provides in theirWindowBuilder
. This only supports a single primary window on web.Ideally, long term, we'd figure out a better pattern for spawning a new canvas element when the window is created dynamically, rather than relying on Bevy's window initialization logic in the renderer. I'm sure this is possible, just need some more consultation with some other Bevy folks to figure out how to do it.
Test with:
cargo build --release --example draw --target wasm32-unknown-unknown wasm-bindgen --out-name draw \ --out-dir examples/wasm/target \ --target web target/wasm32-unknown-unknown/release/examples/draw.wasm basic-http-server examples/wasm