-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Corner frequency and fundamental frequency in PLRedNoise
and PLDMNoise
#1762
Open
abhisrkckl
wants to merge
44
commits into
nanograv:master
Choose a base branch
from
abhisrkckl:redcorner
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhisrkckl
changed the title
Corner frequency and fundamental frequency in
WIP: Corner frequency and fundamental frequency in May 10, 2024
PLRedNoise
and PLDMNoise
PLRedNoise
and PLDMNoise
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1762 +/- ##
==========================================
- Coverage 69.43% 69.32% -0.11%
==========================================
Files 107 106 -1
Lines 24925 24895 -30
Branches 4430 4432 +2
==========================================
- Hits 17306 17258 -48
- Misses 6510 6522 +12
- Partials 1109 1115 +6 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1366
Fundamental frequency
The
TNRedFLow
parameter can control the fundamental frequency of the red noise. The relevant expression iswhere Tspan is the data span.
This definition is adopted to be consistent with tempo2.
The corresponding parameter for the DM noise is
TNDMFLow
. I have kept its semantics similar toTNRedFLow
although it's not yet implemented in tempo2.Corner frequency
When corner frequency is specified, the expression for the power spectrum is
As fc -> 0, this reduces to
The parameter TNRedCorner is defined in tempo2 as