Refactor pint.fitter
#1884
Open
Refactor pint.fitter
#1884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhisrkckl
added
the
awaiting review
abhisrkckl
force-pushed
the
fitter_refact
branch
from
eb55f36 to
02e9cd3
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1884 +/- ##
==========================================
- Coverage 69.84% 69.79% -0.06%
==========================================
Files 110 110
Lines 25740 25674 -66
Branches 4072 4056 -16
==========================================
- Hits 17977 17918 -59
+ Misses 6627 6622 -5
+ Partials 1136 1134 -2 ☔ View full report in Codecov by Sentry. |
scottransom
reviewed
Feb 26, 2025
There was a problem hiding this comment.
Any idea how a change to pintk.py got into this PR?
There was a problem hiding this comment.
A pintk test was failing on my laptop, and this minor change fixes that. It was getting skipped in the CI machine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce code duplication in
pint.fitter, e.g., betweenWLSFitterandDownhillWLSFitter.A side benefit of this is that it simplifies the
Fitterclasses, making it easier to implement #1660.I accidentally merged #1883 into this, so that should be merged first.