-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix PTSwap Output #48
Conversation
The code looks right to me. Is the functionality documented somewhere that with each chain it outputs the acceptance rate of swaps between this chain and the next hotter one? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside from what @kdolum says, you also seem to have committed new versions of two example notebooks. But the notebooks do not seem to have changed, except for the figures. Looking at the figures nothing is updated.
So please remove the ipynb edits from the PR, they do not seem different. Or create a new PR that doesn't contain them
@vhaasteren I will remove the ipynbs and make a separate PR. These are extremely minor errors that my linter picked up. |
@kdolum I've updated the docstring to hopefully make it clear that the function does not return |
Notebook changes have been removed and moved to #49 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me now. Also happy, @kdolum?
Looks good to me now too. |
PTSwap
method to alsoscatter
a numpy array of acceptances allowing the sampler to output PT swap acceptance rates as it did previously.