Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing a chain resume issue #55

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

jeremy-baier
Copy link

See issue 53.

@kdolum
Copy link
Collaborator

kdolum commented Jun 6, 2024

Jeremy, did you verify that with this change it works to resume both when only one sample has been saved and when there are more than that?

@vhaasteren
Copy link
Member

Thank you for figuring this out, @jeremy-baier! Please confirm that it works for the case that @kdolum suggests, and then we can merge.

@jeremy-baier
Copy link
Author

Thanks for the reminder!
I can confirm that this does fix the issue I was seeing.
When I replicate the scenario, I get this message and the sampler proceeds to sample:
Resuming with 1 samples from file representing 1 original samples
Since it just picks up sampling from the original 1 sample, there shouldn’t be any issues with isave or ithin.
Thanks for your help with this, Ken!!

@kdolum
Copy link
Collaborator

kdolum commented Jun 7, 2024

Thanks, @jeremy-baier. Did you also verify that it works in the case where it worked before where there's not just one sample? I've no reason to think it would fail, but it's good to the be careful. Thanks!

@jeremy-baier
Copy link
Author

I can confirm that it does:
Resuming with 2201 samples from file representing 22001 original samples
And I just checked that it will work with an empty chain file and no chain file.

Copy link
Collaborator

@kdolum kdolum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@kdolum kdolum merged commit 5e3bebf into nanograv:master Jun 7, 2024
10 checks passed
@jeremy-baier jeremy-baier deleted the jgb-resume-chain-fix branch June 7, 2024 23:29
@vhaasteren vhaasteren self-assigned this Jun 14, 2024
Copy link
Member

@vhaasteren vhaasteren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants