Fix noise analysis for "narrowband" data with no ECORR #45
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In trying to run the
process_v1.2
notebook on simulated LOFAR data, @FrancescoIraci ran into an issue (#44) wherenoise_utils.add_noise_to_model()
would raise an exception if "narrowband" data didn't have associated ECORR parameters.It turns out that this function was written in an unnecessarily inflexible way: with
using_wideband = False
, it would always try to add ECORR parameters to the model, whether or not they were present in the white noise dictionary returned bynoise_utils.analyze_noise()
. In this case, not finding any, it would raise an exception. (Similarly, withusing_wideband = True
, it would always try to add DMEFAC and DMEQUAD parameters, even if none were present.)This PR changes this behavior to make it more flexible: now, ECORR, DMEFAC, and DMEQUAD parameters should be added if, and only if, they are present in the white noise dictionary, regardless of the value of
using_wideband
, which now only serves to identify the appropriate noise chain directory. This should make it possible to run the notebook on narrowband data without EFAC, or on wideband data without DMEFAC and/or DMEQUAD.