Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #1675 undefined behavior in posix ipc_dialer_dial #1692

Merged
merged 1 commit into from
Sep 14, 2023

Conversation

gdamore
Copy link
Contributor

@gdamore gdamore commented Sep 14, 2023

(This also affects TCP, and fixed there.)

fixes #

Note that the above format should be used in your git commit comments.
You agree that by submitting a PR, you have read and agreed to our
contributing guidelines.

(This also affects TCP, and fixed there.)
@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Merging #1692 (7ff70b6) into master (12002c9) will increase coverage by 1.10%.
Report is 1 commits behind head on master.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #1692      +/-   ##
==========================================
+ Coverage   78.15%   79.26%   +1.10%     
==========================================
  Files          87       89       +2     
  Lines       19390    20224     +834     
==========================================
+ Hits        15155    16031     +876     
+ Misses       4235     4193      -42     
Files Changed Coverage Δ
src/platform/posix/posix_ipcdial.c 56.87% <0.00%> (+0.49%) ⬆️
src/platform/posix/posix_tcpdial.c 75.72% <0.00%> (+9.39%) ⬆️

... and 80 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@gdamore gdamore merged commit a54820f into master Sep 14, 2023
15 of 18 checks passed
@gdamore gdamore deleted the gdamore/bug1675 branch September 14, 2023 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant