Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gdamore/dev2/iwyu #1869

Merged
merged 3 commits into from
Sep 7, 2024
Merged

Gdamore/dev2/iwyu #1869

merged 3 commits into from
Sep 7, 2024

Conversation

gdamore
Copy link
Contributor

@gdamore gdamore commented Sep 7, 2024

fixes #

Note that the above format should be used in your git commit comments.
You agree that by submitting a PR, you have read and agreed to our
contributing guidelines.

This also allows to remove most of the transport headers.
Only zerotier.h sticks around, and only for now.  (We expect to
eject it into a separate module.)
This moves us towards IWYU, which makes life better with clangd.
Copy link

codecov bot commented Sep 7, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 79.90%. Comparing base (381a7c7) to head (619e066).
Report is 3 commits behind head on dev2.0.

Files with missing lines Patch % Lines
src/nng_legacy.c 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           dev2.0    #1869      +/-   ##
==========================================
+ Coverage   79.65%   79.90%   +0.24%     
==========================================
  Files          94       94              
  Lines       21145    21143       -2     
==========================================
+ Hits        16844    16895      +51     
+ Misses       4301     4248      -53     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdamore gdamore merged commit 619e066 into dev2.0 Sep 7, 2024
14 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant