Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gdamore/udp stats tests #1891

Merged
merged 2 commits into from
Oct 13, 2024
Merged

Gdamore/udp stats tests #1891

merged 2 commits into from
Oct 13, 2024

Conversation

gdamore
Copy link
Contributor

@gdamore gdamore commented Oct 13, 2024

fixes #

Note that the above format should be used in your git commit comments.
You agree that by submitting a PR, you have read and agreed to our
contributing guidelines.

There were several bugs here, including use-after-free,
a problem when the copy limit was exceeded, and uninitialized
receive thresholds.
Copy link

codecov bot commented Oct 13, 2024

Codecov Report

Attention: Patch coverage is 79.54545% with 9 lines in your changes missing coverage. Please review.

Project coverage is 79.54%. Comparing base (43d947a) to head (0bef8c0).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/sp/transport/udp/udp.c 79.54% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1891      +/-   ##
==========================================
+ Coverage   79.16%   79.54%   +0.37%     
==========================================
  Files          95       95              
  Lines       22317    22339      +22     
  Branches     3385     3388       +3     
==========================================
+ Hits        17667    17769     +102     
+ Misses       4578     4496      -82     
- Partials       72       74       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdamore gdamore merged commit 0bef8c0 into main Oct 13, 2024
16 checks passed
@gdamore gdamore deleted the gdamore/udp-stats-tests branch October 13, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant