Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cosmetics #10

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Cosmetics #10

wants to merge 13 commits into from

Conversation

mambax7
Copy link
Contributor

@mambax7 mambax7 commented Aug 31, 2019

(Yoda, arrays, etc.)

mambax7 and others added 13 commits December 11, 2017 01:27
@mambax7
Merge pull request #1 from nao-pon/master
2c572fc 
updates
@mambax7
missing _ADMENU_GOOGLEDRIVE
318bd56
@mambax7
Only variables should be assigned by reference
b941f7f
@mambax7
Callable name case mismatched in a call
69dd544
@mambax7
Only variables should be assigned by reference
b93763c
@mambax7
Merge branch 'master' of https://github.com/nao-pon/xelfinder
605e03d
@mambax7
Merge branch 'master' of https://github.com/nao-pon/xelfinder
88729a1
@ImgBotApp
[ImgBot] Optimize images
58075f7 
*Total -- 6.42kb -> 6.10kb (5.04%)

/html/common/js/simplemodal/img/basic/x.png -- 1.04kb -> 0.94kb (9.29%)
/xoops_trust_path/modules/xelfinder/images/module_icon_xcl_org.png -- 2.63kb -> 2.47kb (6.05%)
/xoops_trust_path/modules/xelfinder/images/module_icon.png -- 2.75kb -> 2.68kb (2.45%)
@mambax7
Merge pull request #2 from mambax7/imgbot
686c998 
[ImgBot] Optimize images
@mambax7
Merge branch 'master' of https://github.com/nao-pon/xelfinder
1915a6c
@mambax7
Merge branch 'master' of https://github.com/mambax7/xelfinder
1ce83bf
@mambax7
https://github.com/nao-pon/xelfinder/issues/8
ceb576f 
key was too long
@mambax7
cosmetics (Yoda, arrays, etc.)
da4afe2
@nao-pon
Copy link
Owner

nao-pon commented Aug 31, 2019

@mambax7 Thank you for your PR.

elFinder supports PHP 5.2, so the __DIR__ constant cannot be used.

@mambax7
Copy link
Contributor Author

mambax7 commented Sep 1, 2019 •
edited
Loading

Too bad, since the number of PHP 5.2 users is so small
They are also exposed much more to hacking risk, as the low versions of PHP didn't receive any security updates in years.
When do you plan to eliminate PHP 5.2 and move to higher version as the minimum?

@nao-pon
Copy link
Owner

nao-pon commented Sep 1, 2019

@mambax7 Of course I encourage everyone to use the latest version of PHP. However, raising the minimum version is not related. If the necessary functions for this app are in PHP, that is the minimum version for this app. I don't think there is a reason to break the compatibility and adopt __DIR__.

Also, I don't know who uses which PHP, and I think it should be free for them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mambax7 @nao-pon @ImgBotApp