Some diff fixes #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without these, empty diffs would result in an error instead of empty diffs
Previous if you added something to the replace candidate, it would appear in the diff output with a - prefix instead of a plus
btobolaski
force-pushed
the
fix-empty-diff
branch
from
e2972aa to
d9ddf24
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With empty diffs, I was getting errors instead of a diff. The first commit addresses this.
It also appears that the diff direction was reversed. If I added
to my replacement config, the diff would show:
Which is opposite of the behavior that I would expect (as applying the diff would add those to the running config, not remove them).