Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.4.19 release notes #3

Merged
merged 37 commits into from
Feb 1, 2024
Merged

0.4.19 release notes #3

merged 37 commits into from
Feb 1, 2024

Conversation

Czaki
Copy link
Collaborator

@Czaki Czaki commented Oct 23, 2023

Initial patches for 0.4.19 release

highlight/0.4.19.md Outdated Show resolved Hide resolved
highlight/0.4.19.md Outdated Show resolved Hide resolved
Co-authored-by: Wouter-Michiel Vierdag <[email protected]>
highlight/0.4.19.md Outdated Show resolved Hide resolved
Co-authored-by: Lorenzo Gaifas <[email protected]>
highlight/0.4.19.md Outdated Show resolved Hide resolved
highlight/0.4.19.md Outdated Show resolved Hide resolved
@psobolewskiPhD
Copy link
Member

Small copy edits.

Comment on lines 9 to 11
we expect that in the next release we will ship bundle with pydantic 2.
So if your plugin is using pydantic please make sure that it is compatible with pydantic 2.
([napari/napari/#6358](https://github.com/napari/napari/pull/6358))
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
we expect that in the next release we will ship bundle with pydantic 2.
So if your plugin is using pydantic please make sure that it is compatible with pydantic 2.
([napari/napari/#6358](https://github.com/napari/napari/pull/6358))
we expect the next release to ship with pydantic 2 bundled.
If your plugin is using pydantic please make sure that it is compatible with pydantic 2.
([napari/napari/#6358](https://github.com/napari/napari/pull/6358))

?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope. we will not bundle pydantic 2 in napair. We will ship pydantic 2 in a bundle installer (so it will affect only downloadable executables, not installed from pip/conda).

So if your plugin is using pydantic please make sure that it is compatible with pydantic 2.
([napari/napari/#6358](https://github.com/napari/napari/pull/6358))

Lastly we have fixed performance problem with label layer by move part of calculation on GPU
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Lastly we have fixed performance problem with label layer by move part of calculation on GPU
Lastly we have fixed performance problem with label layer by moving part of calculation on GPU

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm. I think that we will need to rewrite this part totally as we now working on updating of mechanism.

@brisvag
Copy link
Contributor

brisvag commented Nov 29, 2023

This seems like way too much details for the highlights. I would say just enough so people know to use smaller unsigned dtypes if performance is an issue, but no need to explain the how/why and point to all the PR in the highlights.

@psobolewskiPhD
Copy link
Member

Is it worth reminding people of the Convert dtype contextual menu? or is that too far afield.

@Czaki
Copy link
Collaborator Author

Czaki commented Nov 29, 2023

Is it worth reminding people of the Convert dtype contextual menu? or is that too far afield.

I think yes.

This seems like way too much details for the highlights. I would say just enough so people know to use smaller unsigned dtypes if performance is an issue, but no need to explain the how/why and point to all the PR in the highlights.

Maybe yes. I'm not best text writter

highlight/0.4.19.md Outdated Show resolved Hide resolved
highlight/0.4.19.md Outdated Show resolved Hide resolved
highlight/0.4.19.md Outdated Show resolved Hide resolved
highlight/0.4.19.md Outdated Show resolved Hide resolved
highlight/0.4.19.md Outdated Show resolved Hide resolved
highlight/0.4.19.md Outdated Show resolved Hide resolved
Copy link
Contributor

@brisvag brisvag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 typo, but other than that love the new notes!

### BIG improvements to the Labels layer

[#3308](https://github.com/napari/napari/pull/3308) closed *many* long-standing
bugs in the handling of colors in the Labels layer: the color swatch in the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
bugs in the handling of colors in the Labels layer: the color swatch in the
bugs in the handling of colors in the Labels layer: the color switch in the

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uh, the more you know!

@jni
Copy link
Member

jni commented Jan 31, 2024

@Czaki Thanks for the script updates, they look great. Can I push here again? I'll move the API changes note to the relevant section, and I'll make a note in the deprecations section for napari/napari#6542.

@Czaki
Copy link
Collaborator Author

Czaki commented Jan 31, 2024

yes

@jni
Copy link
Member

jni commented Jan 31, 2024

Ok. I put a space in api changes.md based on my reading of the code, but obviously, feel free to update as needed. As far as I'm concerned this in now ready! 😍 🚀

@Czaki Czaki merged commit 49143c4 into main Feb 1, 2024
1 check passed
@Czaki Czaki deleted the 0.4.19_release branch February 1, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants